Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: remoting/host/security_key/security_key_auth_handler.h

Issue 2162083003: Renaming Gnubby and RemoteSecurityKey files/classes/members (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing a GYP build error Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/security_key/security_key_auth_handler.h
diff --git a/remoting/host/security_key/gnubby_auth_handler.h b/remoting/host/security_key/security_key_auth_handler.h
similarity index 46%
rename from remoting/host/security_key/gnubby_auth_handler.h
rename to remoting/host/security_key/security_key_auth_handler.h
index 137a8f7717d1c08a6e18823734e6986d99a60052..f43e1aad2647f441b9fc9644ff0d56543b91dea6 100644
--- a/remoting/host/security_key/gnubby_auth_handler.h
+++ b/remoting/host/security_key/security_key_auth_handler.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef REMOTING_HOST_SECURITY_KEY_GNUBBY_AUTH_HANDLER_H_
-#define REMOTING_HOST_SECURITY_KEY_GNUBBY_AUTH_HANDLER_H_
+#ifndef REMOTING_HOST_SECURITY_KEY_SECURITY_KEY_AUTH_HANDLER_H_
+#define REMOTING_HOST_SECURITY_KEY_SECURITY_KEY_AUTH_HANDLER_H_
#include <memory>
#include <string>
@@ -21,51 +21,52 @@ class ClientSessionDetails;
// Class responsible for proxying authentication data between a local gnubbyd
// and the client.
-class GnubbyAuthHandler {
+class SecurityKeyAuthHandler {
public:
- virtual ~GnubbyAuthHandler() {}
+ virtual ~SecurityKeyAuthHandler() {}
- // Used to send gnubby extension messages to the client.
+ // Used to send security key extension messages to the client.
typedef base::Callback<void(int connection_id, const std::string& data)>
SendMessageCallback;
- // Creates a platform-specific GnubbyAuthHandler.
+ // Creates a platform-specific SecurityKeyAuthHandler.
// All invocations of |send_message_callback| are guaranteed to occur before
- // the underlying GnubbyAuthHandler object is destroyed. It is not safe to
- // destroy the GnubbyAuthHandler object within the callback.
+ // the underlying SecurityKeyAuthHandler object is destroyed. It is not safe
+ // to destroy the SecurityKeyAuthHandler object within the callback.
// |client_session_details| will be valid until this instance is destroyed.
- static std::unique_ptr<GnubbyAuthHandler> Create(
+ static std::unique_ptr<SecurityKeyAuthHandler> Create(
ClientSessionDetails* client_session_details,
const SendMessageCallback& send_message_callback);
#if defined(OS_LINUX)
- // Specify the name of the socket to listen to gnubby requests on.
- static void SetGnubbySocketName(const base::FilePath& gnubby_socket_name);
+ // Specify the name of the socket to listen to security key requests on.
+ static void SetSecurityKeySocketName(
+ const base::FilePath& security_key_socket_name);
#endif // defined(OS_LINUX)
// Sets the callback used to send messages to the client.
virtual void SetSendMessageCallback(const SendMessageCallback& callback) = 0;
- // Creates the platform specific connection to handle gnubby requests.
- virtual void CreateGnubbyConnection() = 0;
+ // Creates the platform specific connection to handle security key requests.
+ virtual void CreateSecurityKeyConnection() = 0;
- // Returns true if |gnubby_connection_id| represents a valid connection.
- virtual bool IsValidConnectionId(int gnubby_connection_id) const = 0;
+ // Returns true if |security_key_connection_id| represents a valid connection.
+ virtual bool IsValidConnectionId(int security_key_connection_id) const = 0;
- // Sends the gnubby response from the client to the local gnubby agent.
- virtual void SendClientResponse(int gnubby_connection_id,
+ // Sends security key response from client to local security key agent.
+ virtual void SendClientResponse(int security_key_connection_id,
const std::string& response) = 0;
- // Closes the gnubby connection represented by |gnubby_connection_id|.
- virtual void SendErrorAndCloseConnection(int gnubby_connection_id) = 0;
+ // Closes key connection represented by |security_key_connection_id|.
+ virtual void SendErrorAndCloseConnection(int security_key_connection_id) = 0;
- // Returns the number of active gnubby connections.
+ // Returns the number of active security key connections.
virtual size_t GetActiveConnectionCountForTest() const = 0;
- // Sets the timeout used when waiting for a gnubby response.
+ // Sets the timeout used when waiting for a security key response.
virtual void SetRequestTimeoutForTest(base::TimeDelta timeout) = 0;
};
} // namespace remoting
-#endif // REMOTING_HOST_SECURITY_KEY_GNUBBY_AUTH_HANDLER_H_
+#endif // REMOTING_HOST_SECURITY_KEY_SECURITY_KEY_AUTH_HANDLER_H_

Powered by Google App Engine
This is Rietveld 408576698