Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1206)

Issue 2162063004: Make assert_selection() to support no BODY element case (Closed)

Created:
4 years, 5 months ago by yosin_UTC9
Modified:
4 years, 5 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make assert_selection() to support no BODY element result This patch makes |assert_selection()| to serialize document element when result document doesn't have a BODY element. This patch is a preparation of http://crrev.com/2131113002, which makes "justyFull" Command to work without BODY element. BUG=n/a TEST=LayoutTests/editing/assert_selection.html Committed: https://crrev.com/8a079b530b47ce80a798f1dac8a3736c51a30558 Cr-Commit-Position: refs/heads/master@{#406503}

Patch Set 1 #

Patch Set 2 : 2016-07-20T12:34:47 #

Total comments: 2

Patch Set 3 : 2016-07-20T13:35:22 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/editing/assert_selection.html View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/assert_selection.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
yosin_UTC9
PTAL
4 years, 5 months ago (2016-07-20 03:40:46 UTC) #6
yoichio
If your goal is to confirm not crashing, how about to introduce assert_selection_not_crash(inputText,tester,description) so that ...
4 years, 5 months ago (2016-07-20 04:20:30 UTC) #7
yosin_UTC9
On 2016/07/20 at 04:20:30, yoichio wrote: > If your goal is to confirm not crashing, ...
4 years, 5 months ago (2016-07-20 04:38:41 UTC) #10
yosin_UTC9
PTAL https://codereview.chromium.org/2162063004/diff/20001/third_party/WebKit/LayoutTests/editing/assert_selection.html File third_party/WebKit/LayoutTests/editing/assert_selection.html (right): https://codereview.chromium.org/2162063004/diff/20001/third_party/WebKit/LayoutTests/editing/assert_selection.html#newcode72 third_party/WebKit/LayoutTests/editing/assert_selection.html:72: 'Serialize document element instead of document.body when is ...
4 years, 5 months ago (2016-07-20 04:39:06 UTC) #11
yoichio
lgtm
4 years, 5 months ago (2016-07-20 04:45:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162063004/40001
4 years, 5 months ago (2016-07-20 05:02:17 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-20 06:05:33 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 06:05:35 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 06:07:15 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8a079b530b47ce80a798f1dac8a3736c51a30558
Cr-Commit-Position: refs/heads/master@{#406503}

Powered by Google App Engine
This is Rietveld 408576698