Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Side by Side Diff: tests/SRGBTest.cpp

Issue 2162063003: Tune linear->sRGB constants to round-trip all bytes. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Perfect 131 Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/opts/SkColorXform_opts.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 Google Inc. 2 * Copyright 2016 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkSRGB.h" 8 #include "SkSRGB.h"
9 #include "SkTypes.h" 9 #include "SkTypes.h"
10 #include "Test.h" 10 #include "Test.h"
11 #include <math.h> 11 #include <math.h>
12 12
13 static uint8_t linear_to_srgb(float l) { 13 static uint8_t linear_to_srgb(float l) {
14 // Round float to int, truncate that to uint8_t. 14 return (uint8_t)sk_linear_to_srgb(Sk4f{l})[0];
15 return (uint8_t)Sk4f_round( sk_linear_to_srgb(Sk4f{l}) )[0];
16 } 15 }
17 16
18 DEF_TEST(sk_linear_to_srgb, r) { 17 DEF_TEST(sk_linear_to_srgb, r) {
19 // Should map 0 -> 0 and 1 -> 1. 18 // All bytes should round trip.
20 REPORTER_ASSERT(r, 0 == linear_to_srgb(0.0f)); 19 for (int i = 0; i < 256; i++) {
21 REPORTER_ASSERT(r, 255 == linear_to_srgb(1.0f)); 20 int actual = linear_to_srgb(sk_linear_from_srgb[i]);
21 if (i != actual) {
22 ERRORF(r, "%d -> %d\n", i, actual);
23 }
24 }
22 25
23 // Should be monotonic between 0 and 1. 26 // Should be monotonic between 0 and 1.
24 // We don't bother checking denorm values.
25 int tolerated_regressions = 0;
26 #if defined(SK_ARM_HAS_NEON)
27 // Values around 0.166016 are usually 72 but drop briefly (41 floats) down t o 71.
28 tolerated_regressions = 1;
29 #endif
30 uint8_t prev = 0; 27 uint8_t prev = 0;
31 for (float f = FLT_MIN; f <= 1.0f; ) { 28 for (float f = FLT_MIN; f <= 1.0f; ) { // We don't bother checking denorm v alues.
32 uint8_t srgb = linear_to_srgb(f); 29 uint8_t srgb = linear_to_srgb(f);
33 30
34 REPORTER_ASSERT(r, srgb >= prev || tolerated_regressions > 0); 31 REPORTER_ASSERT(r, srgb >= prev);
35 if (srgb < prev) { tolerated_regressions--; }
36 prev = srgb; 32 prev = srgb;
37 33
38 union { float flt; uint32_t bits; } pun = { f }; 34 union { float flt; uint32_t bits; } pun = { f };
39 pun.bits++; 35 pun.bits++;
40 f = pun.flt; 36 f = pun.flt;
41 } 37 }
42 } 38 }
OLDNEW
« no previous file with comments | « src/opts/SkColorXform_opts.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698