Split serialization tests further

Split serialization tests further

+ add helpers to compute the split for reuse between tests.

R=whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/6549cd24af8cb80d79ae5d240f234f064ec5a463

[Johnni Winther, 2016-07-20 11:01:27]

johnniwinther@google.com changed reviewers:
+ whesse@google.com

[Johnni Winther, 2016-07-20 11:53:08]

PTAL

[Bill Hesse, 2016-07-20 13:46:45]

lgtm

https://codereview.chromium.org/2162053005/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/serialization/test_helper.dart (right):

https://codereview.chromium.org/2162053005/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/serialization/test_helper.dart:594: /// Return the test
arguments for testing the [index]th segment (1-based) of
I think you should have two functions, one for returning a single test, and
another for returning a computed range.  That is better than overloading
negative numbers.

Could you also check the values against skip and count, to make sure they are
valid?

[Johnni Winther, 2016-07-25 08:30:08]

https://codereview.chromium.org/2162053005/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/serialization/test_helper.dart (right):

https://codereview.chromium.org/2162053005/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/serialization/test_helper.dart:594: /// Return the test
arguments for testing the [index]th segment (1-based) of
On 2016/07/20 13:46:45, Bill Hesse wrote:
> I think you should have two functions, one for returning a single test, and
> another for returning a computed range.  That is better than overloading
> negative numbers.
> 
> Could you also check the values against skip and count, to make sure they are
> valid?
> 

Done.

[Johnni Winther, 2016-07-25 08:36:41]

Description was changed from

==========
Split serialization tests further

+ add helpers to compute the split for reuse between tests.
==========

to

==========
Split serialization tests further

+ add helpers to compute the split for reuse between tests.

R=whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6549cd24af8cb80d79ae5d240f234f064ec5a463
==========

[Johnni Winther, 2016-07-25 08:36:42]

Committed patchset #3 (id:40001) manually as
6549cd24af8cb80d79ae5d240f234f064ec5a463 (presubmit successful).