Issue 2162053004: Separate gathering Delta changes and validation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2162053004: Separate gathering Delta changes and validation. (Closed)

Created:
4 years, 5 months ago by scheglov

Modified:
4 years, 5 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Separate gathering Delta changes and validation. This allows us to handle correctly cycles in dependencies. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/7b7aa3bd432c5938fa81d555c036f51a33ab60c4

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+193 lines, -20 lines)			Patch
M	pkg/analyzer/lib/src/context/cache.dart	View	10 chunks	+94 lines, -11 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/dart.dart	View	6 chunks	+50 lines, -9 lines	0 comments	Download
M	pkg/analyzer/test/src/context/cache_test.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/src/context/context_test.dart	View	1 chunk	+40 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

4 years, 5 months ago (2016-07-20 15:42:41 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7b7aa3bd432c5938fa81d555c036f51a33ab60c4 (presubmit successful).