Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2162033002: Revert "Use the same codepath for NOTIFICATIONS and PUSH_MESSAGING permissions" (Closed)

Created:
4 years, 5 months ago by Irfan
Modified:
4 years, 5 months ago
Reviewers:
raymes
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, harkness+watch_chromium.org, johnme+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Use the same codepath for NOTIFICATIONS and PUSH_MESSAGING permissions" This reverts commit 4f82b403f397fbad2e44fe287c05956fcb7cf282. NotificationPermissionContextTest.PushSecureOriginRequirement introduced by this CL fails on DrMemory TBR=raymes@chromium.org BUG=629514 Committed: https://crrev.com/170641109a0ef22dcff99a03cc4a6ad8610cf742 Cr-Commit-Position: refs/heads/master@{#406291}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+572 lines, -108 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_permission_context.h View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/notifications/notification_permission_context.cc View 2 chunks +4 lines, -22 lines 0 comments Download
M chrome/browser/notifications/notification_permission_context_unittest.cc View 5 chunks +9 lines, -70 lines 0 comments Download
M chrome/browser/permissions/permission_bubble_request_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/permissions/permission_manager.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_browsertest.cc View 6 chunks +26 lines, -3 lines 0 comments Download
A chrome/browser/push_messaging/push_messaging_permission_context.h View 1 chunk +62 lines, -0 lines 0 comments Download
A chrome/browser/push_messaging/push_messaging_permission_context.cc View 1 chunk +139 lines, -0 lines 0 comments Download
A chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc View 1 chunk +314 lines, -0 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_service_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162033002/1
4 years, 5 months ago (2016-07-19 16:20:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 16:25:08 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 16:25:12 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 16:26:56 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/170641109a0ef22dcff99a03cc4a6ad8610cf742
Cr-Commit-Position: refs/heads/master@{#406291}

Powered by Google App Engine
This is Rietveld 408576698