Start using display.mojom.Display in mus+ash.

Start using display.mojom.Display in mus+ash.

Many small changes to use display.mojom.Display and the corresponding
StructTrait.
1. Rename ui.mojom.Display to ui.mojom.WmDisplay.
2. Change ui.mojom.WmDisplay to contain a display.mojom.Display.
3. Delete TypeConverter for ui.mojom.WmDisplay -> display::Display as
   the StructTrait does this automatically now.
4. Change ui.mojom.WindowManager to use display.mojom.Display instead of
   ui.mojom.WmDisplay. It wasn't using the extra fields.
5. Change ui::wm::Display and ui::wm::PlatformDisplay to use C++
   rotation enum instead of mojom enum.
6. Add some missing #includes that the linter was complaining about.

BUG=625876
Committed: https://crrev.com/1c9130aa19e71300506fa73ff259135c6cdba5e6
Cr-Commit-Position: refs/heads/master@{#406545}

[kylechar, 2016-07-19 13:33:17]

Description was changed from

==========
Start using display.mojom.Display in mus+ash.

Many small changes to use display.mojom.Display and the corresponding
StructTrait.
1. Rename ui.mojom.Display to ui.mojom.WmDisplay.
2. Change ui.mojom.WmDisplay to contain a display.mojom.Display.
3. Delete TypeConverter for ui.mojom.WmDisplay -> display::Display as
   the StructTrait does this automatically now.
4. Change ui.mojom.WindowManager to use display.mojom.Display instead of
   ui.mojom.WmDisplay. It wasn't using the extra fields.
5. Change ui::wm::Display to use C++ rotation enum instead of mojom
   enum.
6. Add some missing #includes that the linter was complaining about.

BUG=625876
==========

to

==========
Start using display.mojom.Display in mus+ash.

Many small changes to use display.mojom.Display and the corresponding
StructTrait.
1. Rename ui.mojom.Display to ui.mojom.WmDisplay.
2. Change ui.mojom.WmDisplay to contain a display.mojom.Display.
3. Delete TypeConverter for ui.mojom.WmDisplay -> display::Display as
   the StructTrait does this automatically now.
4. Change ui.mojom.WindowManager to use display.mojom.Display instead of
   ui.mojom.WmDisplay. It wasn't using the extra fields.
5. Change ui::wm::Display and ui::wm::PlatformDisplay to use C++
   rotation enum instead of mojom enum.
6. Add some missing #includes that the linter was complaining about.

BUG=625876
==========

[kylechar, 2016-07-19 13:35:11]

kylechar@chromium.org changed reviewers:
+ sky@chromium.org, tsepez@chromium.org

[kylechar, 2016-07-19 13:35:12]

+sky for OWNERS on basically everything, +tsepez for security review.

[Tom Sepez, 2016-07-19 16:22:25]

mojom lgtm

https://codereview.chromium.org/2161993002/diff/20001/services/ui/ws/display.cc
File services/ui/ws/display.cc (right):

https://codereview.chromium.org/2161993002/diff/20001/services/ui/ws/display....
services/ui/ws/display.cc:99: // TODO(sky): Display should know it's origin.
nit: its

[sky, 2016-07-19 18:07:15]

https://codereview.chromium.org/2161993002/diff/20001/services/ui/public/inte...
File services/ui/public/interfaces/window_manager_constants.mojom (right):

https://codereview.chromium.org/2161993002/diff/20001/services/ui/public/inte...
services/ui/public/interfaces/window_manager_constants.mojom:42: struct
WmDisplay {
This names implies the display is for or from the windowmanager, which isn't
quite right. WDYT of WsDisplay, as in Window Server Display?

[sky, 2016-07-19 18:07:49]

On 2016/07/19 18:07:15, sky wrote:
>
https://codereview.chromium.org/2161993002/diff/20001/services/ui/public/inte...
> File services/ui/public/interfaces/window_manager_constants.mojom (right):
> 
>
https://codereview.chromium.org/2161993002/diff/20001/services/ui/public/inte...
> services/ui/public/interfaces/window_manager_constants.mojom:42: struct
> WmDisplay {
> This names implies the display is for or from the windowmanager, which isn't
> quite right. WDYT of WsDisplay, as in Window Server Display?

I'm not dead set on window server here, but I feel that calling the structure
Window Manager Display is mildly confusing when most clients don't get it from
the window manager.

[kylechar, 2016-07-19 18:55:20]

https://codereview.chromium.org/2161993002/diff/20001/services/ui/public/inte...
File services/ui/public/interfaces/window_manager_constants.mojom (right):

https://codereview.chromium.org/2161993002/diff/20001/services/ui/public/inte...
services/ui/public/interfaces/window_manager_constants.mojom:42: struct
WmDisplay {
On 2016/07/19 18:07:15, sky wrote:
> This names implies the display is for or from the windowmanager, which isn't
> quite right. WDYT of WsDisplay, as in Window Server Display?

WsDisplay it is.

https://codereview.chromium.org/2161993002/diff/20001/services/ui/ws/display.cc
File services/ui/ws/display.cc (right):

https://codereview.chromium.org/2161993002/diff/20001/services/ui/ws/display....
services/ui/ws/display.cc:99: // TODO(sky): Display should know it's origin.
On 2016/07/19 16:22:25, Tom Sepez wrote:
> nit: its

Done.

[sky, 2016-07-19 19:11:19]

LGTM

[kylechar, 2016-07-19 20:06:53]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-07-19 20:06:53]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2161993002/#ps40001
(title: "Fixes.")

[commit-bot: I haz the power, 2016-07-19 20:07:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 23:38:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 23:38:34]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[kylechar, 2016-07-20 12:31:30]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2016-07-20 12:32:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 13:28:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-20 13:29:52]

Description was changed from

==========
Start using display.mojom.Display in mus+ash.

Many small changes to use display.mojom.Display and the corresponding
StructTrait.
1. Rename ui.mojom.Display to ui.mojom.WmDisplay.
2. Change ui.mojom.WmDisplay to contain a display.mojom.Display.
3. Delete TypeConverter for ui.mojom.WmDisplay -> display::Display as
   the StructTrait does this automatically now.
4. Change ui.mojom.WindowManager to use display.mojom.Display instead of
   ui.mojom.WmDisplay. It wasn't using the extra fields.
5. Change ui::wm::Display and ui::wm::PlatformDisplay to use C++
   rotation enum instead of mojom enum.
6. Add some missing #includes that the linter was complaining about.

BUG=625876
==========

to

==========
Start using display.mojom.Display in mus+ash.

Many small changes to use display.mojom.Display and the corresponding
StructTrait.
1. Rename ui.mojom.Display to ui.mojom.WmDisplay.
2. Change ui.mojom.WmDisplay to contain a display.mojom.Display.
3. Delete TypeConverter for ui.mojom.WmDisplay -> display::Display as
   the StructTrait does this automatically now.
4. Change ui.mojom.WindowManager to use display.mojom.Display instead of
   ui.mojom.WmDisplay. It wasn't using the extra fields.
5. Change ui::wm::Display and ui::wm::PlatformDisplay to use C++
   rotation enum instead of mojom enum.
6. Add some missing #includes that the linter was complaining about.

BUG=625876

Committed: https://crrev.com/1c9130aa19e71300506fa73ff259135c6cdba5e6
Cr-Commit-Position: refs/heads/master@{#406545}
==========

[commit-bot: I haz the power, 2016-07-20 13:29:56]

Patchset 3 (id:??) landed as
https://crrev.com/1c9130aa19e71300506fa73ff259135c6cdba5e6
Cr-Commit-Position: refs/heads/master@{#406545}