Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10539)

Unified Diff: chrome/renderer/autofill/form_autofill_browsertest.cc

Issue 2161963003: Make autofill dropdown to obey text-align: left|right CSS property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/autofill/form_autofill_browsertest.cc
diff --git a/chrome/renderer/autofill/form_autofill_browsertest.cc b/chrome/renderer/autofill/form_autofill_browsertest.cc
index 4ea54a0a719a9b1aeb1697fcada02cd423409d0f..1945424ef6fb7e7f1b284455b55c14233411dc77 100644
--- a/chrome/renderer/autofill/form_autofill_browsertest.cc
+++ b/chrome/renderer/autofill/form_autofill_browsertest.cc
@@ -2081,6 +2081,37 @@ TEST_F(FormAutofillTest, DetectTextDirectionWhenStyleAndDIRAttributMixed) {
EXPECT_EQ(base::i18n::LEFT_TO_RIGHT, result.text_direction);
}
+TEST_F(FormAutofillTest, TextAlignOverridesDirection) {
+ // text-align: right
+ LoadHTML("<STYLE>input{direction:ltr;text-align:right}</STYLE>"
+ "<FORM>"
+ " <INPUT type='text' id='element'/>"
+ "</FORM>");
+
+ WebFrame* frame = GetMainFrame();
+ ASSERT_NE(nullptr, frame);
+
+ WebFormControlElement element = GetFormControlElementById("element");
+
+ FormFieldData result;
+ WebFormControlElementToFormField(element, EXTRACT_VALUE, &result);
+ EXPECT_EQ(base::i18n::RIGHT_TO_LEFT, result.text_direction);
+
+ // text-align: left
+ LoadHTML("<STYLE>input{direction:rtl;text-align:left}</STYLE>"
+ "<FORM>"
+ " <INPUT type='text' id='element'/>"
+ "</FORM>");
+
+ frame = GetMainFrame();
+ ASSERT_NE(nullptr, frame);
+
+ element = GetFormControlElementById("element");
+
+ WebFormControlElementToFormField(element, EXTRACT_VALUE, &result);
+ EXPECT_EQ(base::i18n::LEFT_TO_RIGHT, result.text_direction);
+}
+
TEST_F(FormAutofillTest,
DetectTextDirectionWhenParentHasBothDIRAttributeAndStyle) {
LoadHTML("<STYLE>form{direction:ltr}</STYLE>"

Powered by Google App Engine
This is Rietveld 408576698