Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: test/mjsunit/stack-traces-overflow.js

Issue 2161953003: Remove stack overflow boilerplate (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/messages.cc ('K') | « src/messages.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/stack-traces-overflow.js
diff --git a/test/mjsunit/stack-traces-overflow.js b/test/mjsunit/stack-traces-overflow.js
index 706f8fcef914b2a59d866161401f400e96691e64..d0a0a33abab4e1e4006ec12d92d17896a093bfc9 100644
--- a/test/mjsunit/stack-traces-overflow.js
+++ b/test/mjsunit/stack-traces-overflow.js
@@ -40,7 +40,7 @@ try {
overflow();
} catch (e) {
var first_frame = e.stack.split("\n")[1]
- assertTrue(first_frame.indexOf("stack-traces-overflow.js:30:18") > 0);
+ assertTrue(first_frame.indexOf("stack-traces-overflow.js:32:3") > 0);
Yang 2016/07/19 15:06:47 why does this change? Shouldn't we notice the stac
jgruber 2016/07/20 14:48:39 Yes. I fixed this by changing the way we determine
}
// Test stack trace getter and setter.
« src/messages.cc ('K') | « src/messages.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698