Remove stack overflow boilerplate

src/builtins/builtins-error.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins/builtins.h"
 #include "src/builtins/builtins-utils.h"
 
 #include "src/accessors.h"
 #include "src/bootstrapper.h"
+#include "src/messages.h"
 #include "src/property-descriptor.h"
 #include "src/string-builder.h"
 
 namespace v8 {
 namespace internal {
 
 // ES6 section 19.5.1.1 Error ( message )
 BUILTIN(ErrorConstructor) {
   HandleScope scope(isolate);
-
-  // 1. If NewTarget is undefined, let newTarget be the active function object,
-  // else let newTarget be NewTarget.
-
-  Handle<JSFunction> target = args.target<JSFunction>();
-  Handle<JSReceiver> new_target;
-  if (args.new_target()->IsJSReceiver()) {
-    new_target = Handle<JSReceiver>::cast(args.new_target());
-  } else {
-    new_target = target;
-  }
-
-  // 2. Let O be ? OrdinaryCreateFromConstructor(newTarget, "%ErrorPrototype%",
-  //    « [[ErrorData]] »).
-  Handle<JSObject> err;
-  ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, err,
-                                     JSObject::New(target, new_target));
-
-  // 3. If message is not undefined, then
-  //  a. Let msg be ? ToString(message).
-  //  b. Let msgDesc be the PropertyDescriptor{[[Value]]: msg, [[Writable]]:
-  //     true, [[Enumerable]]: false, [[Configurable]]: true}.
-  //  c. Perform ! DefinePropertyOrThrow(O, "message", msgDesc).
-  // 4. Return O.
-
-  Handle<Object> msg = args.atOrUndefined(isolate, 1);
-  if (!msg->IsUndefined(isolate)) {
-    Handle<String> msg_string;
-    ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, msg_string,
-                                       Object::ToString(isolate, msg));
-    RETURN_FAILURE_ON_EXCEPTION(
-        isolate,
-        JSObject::SetOwnPropertyIgnoreAttributes(
-            err, isolate->factory()->message_string(), msg_string, DONT_ENUM));
-  }
-
-  // Capture the stack trace unless we're setting up.
-  if (!isolate->bootstrapper()->IsActive()) {
-    // Optionally capture a more detailed stack trace for the message.
-    RETURN_FAILURE_ON_EXCEPTION(isolate,
-                                isolate->CaptureAndSetDetailedStackTrace(err));
-    // Capture a simple stack trace for the stack property.
-    RETURN_FAILURE_ON_EXCEPTION(isolate,
-                                isolate->CaptureAndSetSimpleStackTrace(err));
-  }
-
-  return *err;
+  RETURN_RESULT_OR_FAILURE(
+      isolate, ConstructError(isolate, args.target<JSFunction>(),
+                              Handle<Object>::cast(args.new_target()),
+                              args.atOrUndefined(isolate, 1), SKIP_FIRST));
 }
 
 // static
 BUILTIN(ErrorCaptureStackTrace) {
   HandleScope scope(isolate);
   Handle<Object> object_obj = args.atOrUndefined(isolate, 1);
   if (!object_obj->IsJSObject()) {
     THROW_NEW_ERROR_RETURN_FAILURE(
         isolate, NewTypeError(MessageTemplate::kInvalidArgument, object_obj));
   }
   Handle<JSObject> object = Handle<JSObject>::cast(object_obj);
   Handle<Object> caller = args.atOrUndefined(isolate, 2);
+  FrameSkipMode mode = caller->IsJSFunction() ? SKIP_UNTIL_SEEN : SKIP_NONE;
 
   // TODO(jgruber): Eagerly format the stack trace and remove accessors.h
   // include.
 
   // Handle writes to the global object.
 
   if (object->IsJSGlobalProxy()) {
     Map* map = object->map();
     if (map->has_hidden_prototype()) {
       object = handle(JSGlobalObject::cast(map->prototype()), isolate);
@@ skipping 41 matching lines @@
           Map::CopyInsertDescriptor(map, &d, INSERT_TRANSITION);
       JSObject::MigrateToMap(object, new_map, 1);
     }
   }
 
   // Collect the stack trace.
 
   RETURN_FAILURE_ON_EXCEPTION(isolate,
                               isolate->CaptureAndSetDetailedStackTrace(object));
   RETURN_FAILURE_ON_EXCEPTION(
-      isolate, isolate->CaptureAndSetSimpleStackTrace(object, caller));
+      isolate, isolate->CaptureAndSetSimpleStackTrace(object, mode, caller));
 
   return *isolate->factory()->undefined_value();
 }
 
 namespace {
 
 MaybeHandle<String> GetStringPropertyOrDefault(Isolate* isolate,
                                                Handle<JSReceiver> recv,
                                                Handle<String> key,
                                                Handle<String> default_str) {
@@ skipping 51 matching lines @@
   // the code unit 0x0020 (SPACE), and msg.
   IncrementalStringBuilder builder(isolate);
   builder.AppendString(name);
   builder.AppendCString(": ");
   builder.AppendString(msg);
   RETURN_RESULT_OR_FAILURE(isolate, builder.Finish());
 }
 
 }  // namespace internal
 }  // namespace v8