Remove stack overflow boilerplate

test/mjsunit/stack-traces-overflow.js

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 22 matching lines @@
 }
 function rec1(a) { rec1(a+1); }
 function rec2(a) { rec3(a+1); }
 function rec3(a) { rec2(a+1); }
 
 // Test stack trace has correct function location at top of the stack.
 try {
   overflow();
 } catch (e) {
   var first_frame = e.stack.split("\n")[1]
-  assertTrue(first_frame.indexOf("stack-traces-overflow.js:30:18") > 0);
+  assertTrue(first_frame.indexOf("stack-traces-overflow.js:32:3") > 0);

[Yang, 2016/07/19 15:06:47]

why does this change? Shouldn't we notice the stack overflow on function entry?
Is it because we skip the first frame on the stack?

[jgruber, 2016/07/20 14:48:39]

Yes. I fixed this by changing the way we determine frame skipping behavior; it
is now explicitly passed into CaptureSimpleStackTrace. 

 }
 
 // Test stack trace getter and setter.
 try {
   rec1(0);
 } catch (e) {
   assertTrue(e.stack.indexOf("rec1") > 0);
   e.stack = "123";
   assertEquals("123", e.stack);
 }
@@ skipping 90 matching lines @@
   assertEquals("abc", e.stack);
 }
 
 Error.stackTraceLimit = 3;
 Error = "";  // Overwrite Error in the global object.
 try {
   rec1(0);
 } catch (e) {
   assertEquals(4, e.stack.split('\n').length);
 }