OLD | NEW |
---|---|
1 // Copyright 2012 the V8 project authors. All rights reserved. | 1 // Copyright 2012 the V8 project authors. All rights reserved. |
2 // Redistribution and use in source and binary forms, with or without | 2 // Redistribution and use in source and binary forms, with or without |
3 // modification, are permitted provided that the following conditions are | 3 // modification, are permitted provided that the following conditions are |
4 // met: | 4 // met: |
5 // | 5 // |
6 // * Redistributions of source code must retain the above copyright | 6 // * Redistributions of source code must retain the above copyright |
7 // notice, this list of conditions and the following disclaimer. | 7 // notice, this list of conditions and the following disclaimer. |
8 // * Redistributions in binary form must reproduce the above | 8 // * Redistributions in binary form must reproduce the above |
9 // copyright notice, this list of conditions and the following | 9 // copyright notice, this list of conditions and the following |
10 // disclaimer in the documentation and/or other materials provided | 10 // disclaimer in the documentation and/or other materials provided |
(...skipping 22 matching lines...) Expand all Loading... | |
33 } | 33 } |
34 function rec1(a) { rec1(a+1); } | 34 function rec1(a) { rec1(a+1); } |
35 function rec2(a) { rec3(a+1); } | 35 function rec2(a) { rec3(a+1); } |
36 function rec3(a) { rec2(a+1); } | 36 function rec3(a) { rec2(a+1); } |
37 | 37 |
38 // Test stack trace has correct function location at top of the stack. | 38 // Test stack trace has correct function location at top of the stack. |
39 try { | 39 try { |
40 overflow(); | 40 overflow(); |
41 } catch (e) { | 41 } catch (e) { |
42 var first_frame = e.stack.split("\n")[1] | 42 var first_frame = e.stack.split("\n")[1] |
43 assertTrue(first_frame.indexOf("stack-traces-overflow.js:30:18") > 0); | 43 assertTrue(first_frame.indexOf("stack-traces-overflow.js:32:3") > 0); |
Yang
2016/07/19 15:06:47
why does this change? Shouldn't we notice the stac
jgruber
2016/07/20 14:48:39
Yes. I fixed this by changing the way we determine
| |
44 } | 44 } |
45 | 45 |
46 // Test stack trace getter and setter. | 46 // Test stack trace getter and setter. |
47 try { | 47 try { |
48 rec1(0); | 48 rec1(0); |
49 } catch (e) { | 49 } catch (e) { |
50 assertTrue(e.stack.indexOf("rec1") > 0); | 50 assertTrue(e.stack.indexOf("rec1") > 0); |
51 e.stack = "123"; | 51 e.stack = "123"; |
52 assertEquals("123", e.stack); | 52 assertEquals("123", e.stack); |
53 } | 53 } |
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
144 assertEquals("abc", e.stack); | 144 assertEquals("abc", e.stack); |
145 } | 145 } |
146 | 146 |
147 Error.stackTraceLimit = 3; | 147 Error.stackTraceLimit = 3; |
148 Error = ""; // Overwrite Error in the global object. | 148 Error = ""; // Overwrite Error in the global object. |
149 try { | 149 try { |
150 rec1(0); | 150 rec1(0); |
151 } catch (e) { | 151 } catch (e) { |
152 assertEquals(4, e.stack.split('\n').length); | 152 assertEquals(4, e.stack.split('\n').length); |
153 } | 153 } |
OLD | NEW |