Remove stack overflow boilerplate

src/isolate.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/isolate.h"
 
 #include <stdlib.h>
 
 #include <fstream>  // NOLINT(readability/streams)
 #include <sstream>
@@ skipping 942 matching lines @@
     VMState<EXTERNAL> state(this);
     return callback(v8::Utils::ToLocal(accessing_context),
                     v8::Utils::ToLocal(receiver), v8::Utils::ToLocal(data));
   }
 }
 
 
 Object* Isolate::StackOverflow() {
   DisallowJavascriptExecution no_js(this);
   HandleScope scope(this);
-  // At this point we cannot create an Error object using its javascript
-  // constructor.  Instead, we copy the pre-constructed boilerplate and
-  // attach the stack trace as a hidden property.
   Handle<Object> exception;
   if (bootstrapper()->IsActive()) {
-    // There is no boilerplate to use during bootstrapping.
     exception = factory()->NewStringFromAsciiChecked(

[Yang, 2016/07/19 15:06:46]

I wonder whether we could remove this special case. What happens if we have a
stack overflow in our native JS code at bootstrapping, and go the other path? It
should still just work, right?

[jgruber, 2016/07/20 14:48:39]

Done. Will update the other sites that check for bootstrapping in an upcoming
commit.

         MessageTemplate::TemplateString(MessageTemplate::kStackOverflow));
   } else {
-    Handle<JSObject> boilerplate = stack_overflow_boilerplate();
-    Handle<JSObject> copy = factory()->CopyJSObject(boilerplate);
-    CaptureAndSetSimpleStackTrace(copy, factory()->undefined_value());
-    exception = copy;
+    // Disable detailed stack trace collection while generating the stack
+    // overflow error.
+    bool old_detailed_enabled = capture_stack_trace_for_uncaught_exceptions_;
+    capture_stack_trace_for_uncaught_exceptions_ = false;
+
+    Handle<JSFunction> fun = range_error_function();
+    Handle<Object> msg = factory()->NewStringFromAsciiChecked(
+        MessageTemplate::TemplateString(MessageTemplate::kStackOverflow));
+    exception = handle(ConstructError(this, fun, fun, msg), this);

[Yang, 2016/07/19 15:06:46]

What if we have an exception in ConstructError? We would wrap the exception
sentinel into a handle.

[jgruber, 2016/07/20 14:48:39]

Good catch. Done.

+
+    capture_stack_trace_for_uncaught_exceptions_ = old_detailed_enabled;
   }
   Throw(*exception, nullptr);
 
 #ifdef VERIFY_HEAP
   if (FLAG_verify_heap && FLAG_stress_compaction) {
     heap()->CollectAllGarbage(Heap::kNoGCFlags, "trigger compaction");
   }
 #endif  // VERIFY_HEAP
 
   return heap()->exception();
@@ skipping 2143 matching lines @@
   // Then check whether this scope intercepts.
   if ((flag & intercept_mask_)) {
     intercepted_flags_ |= flag;
     return true;
   }
   return false;
 }
 
 }  // namespace internal
 }  // namespace v8