[crankshaft] Guard against side effects in Array.prototype.shift lowering.

[crankshaft] Guard against side effects in Array.prototype.shift lowering.

We need to pay attention to potential side effects from parameter
evaluation when inlining the fast case Array.prototype.shift.

R=yangguo@chromium.org
BUG=chromium:614644
Committed: https://crrev.com/173313e297ffa94a29fdc9612921df53a92f50c8
Cr-Commit-Position: refs/heads/master@{#37850}

[Benedikt Meurer, 2016-07-19 05:03:45]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 05:03:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-07-19 05:04:14]

Hey Yang,

Here's a quickfix for Array.p.shift in Crankshaft.
Please take a look.

Thanks,
Benedikt

[commit-bot: I haz the power, 2016-07-19 05:29:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 05:29:00]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-07-19 06:38:27]

lgtm

[Benedikt Meurer, 2016-07-19 06:39:44]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-07-19 06:39:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 06:42:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-19 06:42:51]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 06:43:13]

Description was changed from

==========
[crankshaft] Guard against side effects in Array.prototype.shift lowering.

We need to pay attention to potential side effects from parameter
evaluation when inlining the fast case Array.prototype.shift.

R=yangguo@chromium.org
BUG=chromium:614644
==========

to

==========
[crankshaft] Guard against side effects in Array.prototype.shift lowering.

We need to pay attention to potential side effects from parameter
evaluation when inlining the fast case Array.prototype.shift.

R=yangguo@chromium.org
BUG=chromium:614644

Committed: https://crrev.com/173313e297ffa94a29fdc9612921df53a92f50c8
Cr-Commit-Position: refs/heads/master@{#37850}
==========

[commit-bot: I haz the power, 2016-07-19 06:43:14]

Patchset 1 (id:??) landed as
https://crrev.com/173313e297ffa94a29fdc9612921df53a92f50c8
Cr-Commit-Position: refs/heads/master@{#37850}