Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 216193003: DevTools: Fix how navigator reveals and enames files after recent refactorings. (Closed)

Created:
6 years, 9 months ago by vsevik
Modified:
6 years, 9 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Fix how navigator reveals and renames files after recent refactorings. R=pfeldman@chromium.org, pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170316

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/devtools/front_end/NavigatorView.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vsevik
PTAL
6 years, 9 months ago (2014-03-28 10:49:24 UTC) #1
pfeldman
lgtm
6 years, 9 months ago (2014-03-28 10:56:03 UTC) #2
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 9 months ago (2014-03-28 10:56:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/216193003/1
6 years, 9 months ago (2014-03-28 10:56:31 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 12:04:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-28 12:04:39 UTC) #6
vsevik
6 years, 9 months ago (2014-03-28 12:10:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r170316 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698