components/browser_sync/browser/profile_sync_service_unittest.cc - Issue 2161863002: [Sync] Don't start up sync when FirstSetupCompleted is false and no setup in progress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browser_sync/browser/profile_sync_service_unittest.cc

Issue 2161863002: [Sync] Don't start up sync when FirstSetupCompleted is false and no setup in progress (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/browser_sync/browser/profile_sync_service_startup_unittest.cc ('k') | components/sync_driver/startup_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/browser_sync/browser/profile_sync_service_unittest.cc

diff --git a/components/browser_sync/browser/profile_sync_service_unittest.cc b/components/browser_sync/browser/profile_sync_service_unittest.cc

index 5ac0adfcdd4bae556e05914baa7c9fcd5ed72afd..e53e159d1dff644b9f21902a622d19588a4fe1a8 100644

--- a/components/browser_sync/browser/profile_sync_service_unittest.cc

+++ b/components/browser_sync/browser/profile_sync_service_unittest.cc

@@ -416,13 +416,12 @@ TEST_F(ProfileSyncServiceTest, SuccessfulInitialization) {

}

// Verify that an initialization where first setup is not complete does not

-// purge preferences and/or the directory.

+// start up the backend.

TEST_F(ProfileSyncServiceTest, NeedsConfirmation) {

prefs()->SetManagedPref(sync_driver::prefs::kSyncManaged,

new base::FundamentalValue(false));

IssueTestTokens();

CreateService(ProfileSyncService::MANUAL_START);

- ExpectSyncBackendHostCreation(1);

sync_driver::SyncPrefs sync_prefs(prefs());

base::Time now = base::Time::Now();

sync_prefs.SetLastSyncedTime(now);