Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2161853002: Remove dead full snapshot support from the recursive descent serializer. (Closed)

Created:
4 years, 5 months ago by rmacnak
Modified:
4 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove dead full snapshot support from the recursive descent serializer. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/4b369f6a0cdda8e48aaaad63d2dbf6829b0b1baf

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -1120 lines) Patch
M runtime/vm/dart_api_message.cc View 1 3 chunks +1 line, -6 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +3 lines, -11 lines 0 comments Download
M runtime/vm/raw_object.h View 6 chunks +0 lines, -7 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 84 chunks +156 lines, -453 lines 0 comments Download
M runtime/vm/snapshot.h View 1 2 9 chunks +1 line, -97 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 2 16 chunks +45 lines, -543 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
rmacnak
4 years, 5 months ago (2016-07-18 23:15:33 UTC) #3
siva
lgtm
4 years, 5 months ago (2016-07-20 00:13:31 UTC) #5
rmacnak
4 years, 5 months ago (2016-07-20 00:50:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
4b369f6a0cdda8e48aaaad63d2dbf6829b0b1baf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698