Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 216183005: Refactor CSS rules for the shift-key. (Closed)

Created:
6 years, 8 months ago by rsadam
Modified:
6 years, 8 months ago
Reviewers:
kevers
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Refactor CSS rules for the shift-key. BUG=357714 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260470

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased on master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -62 lines) Patch
M ui/keyboard/resources/elements/kb-key.html View 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/resources/elements/kb-shift-key.html View 1 chunk +22 lines, -55 lines 0 comments Download
M ui/keyboard/resources/main.css View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
rsadam
Kevers PTAL! https://codereview.chromium.org/216183005/diff/1/ui/keyboard/resources/elements/kb-shift-key.html File ui/keyboard/resources/elements/kb-shift-key.html (right): https://codereview.chromium.org/216183005/diff/1/ui/keyboard/resources/elements/kb-shift-key.html#newcode37 ui/keyboard/resources/elements/kb-shift-key.html:37: <shadow></shadow> <shadow> reuses the ancestors shadow-root, which ...
6 years, 8 months ago (2014-03-28 19:00:15 UTC) #1
kevers
lgtm
6 years, 8 months ago (2014-03-28 19:28:02 UTC) #2
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 8 months ago (2014-03-28 19:28:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/216183005/1
6 years, 8 months ago (2014-03-28 19:29:55 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-28 20:50:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-28 20:50:12 UTC) #6
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 8 months ago (2014-03-28 22:04:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/216183005/1
6 years, 8 months ago (2014-03-28 22:04:37 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-28 23:44:54 UTC) #9
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-03-28 23:44:54 UTC) #10
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 8 months ago (2014-03-29 01:29:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/216183005/1
6 years, 8 months ago (2014-03-29 01:30:30 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 03:07:07 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-29 03:07:07 UTC) #14
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 8 months ago (2014-03-29 16:57:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/216183005/1
6 years, 8 months ago (2014-03-29 16:57:28 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 17:49:52 UTC) #17
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=290888
6 years, 8 months ago (2014-03-29 17:49:53 UTC) #18
rsadam
Rebased on master.
6 years, 8 months ago (2014-03-29 18:23:03 UTC) #19
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 8 months ago (2014-03-29 18:23:10 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/216183005/20001
6 years, 8 months ago (2014-03-29 18:23:24 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 20:00:07 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-29 20:00:08 UTC) #23
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 8 months ago (2014-03-30 20:05:41 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/216183005/20001
6 years, 8 months ago (2014-03-30 20:05:49 UTC) #25
commit-bot: I haz the power
6 years, 8 months ago (2014-03-30 21:35:12 UTC) #26
Message was sent while issue was closed.
Change committed as 260470

Powered by Google App Engine
This is Rietveld 408576698