|
|
DescriptionRefactor CSS rules for the shift-key.
BUG=357714
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260470
Patch Set 1 #
Total comments: 1
Patch Set 2 : Rebased on master. #
Messages
Total messages: 26 (0 generated)
Kevers PTAL! https://codereview.chromium.org/216183005/diff/1/ui/keyboard/resources/elemen... File ui/keyboard/resources/elements/kb-shift-key.html (right): https://codereview.chromium.org/216183005/diff/1/ui/keyboard/resources/elemen... ui/keyboard/resources/elements/kb-shift-key.html:37: <shadow></shadow> <shadow> reuses the ancestors shadow-root, which means we don't need to duplicate rules.
lgtm
The CQ bit was checked by rsadam@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/216183005/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
The CQ bit was checked by rsadam@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/216183005/1
The CQ bit was unchecked by commit-bot@chromium.org
Commit queue rejected this change because the description was changed between the time the change entered the commit queue and the time it was ready to commit. You can safely check the commit box again.
The CQ bit was checked by rsadam@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/216183005/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
The CQ bit was checked by rsadam@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/216183005/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
Rebased on master.
The CQ bit was checked by rsadam@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/216183005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
The CQ bit was checked by rsadam@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/216183005/20001
Message was sent while issue was closed.
Change committed as 260470 |