Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 216173006: Oilpan: Initialize the size of InterporableValue::m_values in the constructor (Closed)

Created:
6 years, 9 months ago by haraken
Modified:
6 years, 9 months ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Oilpan: Initialize the size of InterporableValue::m_values in the constructor This is a simple follow-up CL for r170298. We should initialize the vector in the constructor and avoid calling resize(). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170328

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M Source/core/animation/InterpolableValue.h View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
haraken
PTAL
6 years, 9 months ago (2014-03-28 12:04:10 UTC) #1
Mads Ager (chromium)
LGTM
6 years, 9 months ago (2014-03-28 12:10:16 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-28 12:14:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/216173006/1
6 years, 9 months ago (2014-03-28 12:14:24 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 14:22:45 UTC) #5
Message was sent while issue was closed.
Change committed as 170328

Powered by Google App Engine
This is Rietveld 408576698