Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 2161693003: Remove HiResEventTimeStamp runtime flag (status=stable) (Closed)

Created:
4 years, 5 months ago by rwlbuis
Modified:
4 years, 4 months ago
Reviewers:
majidvp, Mike West
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HiResEventTimeStamp runtime flag (status=stable) This also removes the now unused m_createTime member variable. BUG=402536, 605501 Committed: https://crrev.com/cf2cd6b49ba5aed9c7229dda27c5c5d8db96fc41 Cr-Commit-Position: refs/heads/master@{#408087}

Patch Set 1 #

Patch Set 2 : V2 #

Total comments: 1

Patch Set 3 : Update Event.idl #

Patch Set 4 : Change comment in Event.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -28 lines) Patch
M third_party/WebKit/Source/core/events/Event.h View 1 2 3 2 chunks +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/events/Event.cpp View 1 2 2 chunks +3 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/events/Event.idl View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (10 generated)
rwlbuis
Remove HiResEventTimeStamp runtime flag (status=stable) BUG=402536
4 years, 5 months ago (2016-07-19 14:28:26 UTC) #1
rwlbuis
PTAL.
4 years, 5 months ago (2016-07-19 19:52:32 UTC) #5
majidvp
Thanks. Please also mention issue 605501 in the description. lgtm with nit. https://codereview.chromium.org/2161693003/diff/20001/third_party/WebKit/Source/core/events/Event.h File third_party/WebKit/Source/core/events/Event.h ...
4 years, 5 months ago (2016-07-22 17:53:02 UTC) #6
rwlbuis
On 2016/07/22 17:53:02, majidvp wrote: > Thanks. Please also mention issue 605501 in the description. ...
4 years, 5 months ago (2016-07-22 18:08:35 UTC) #8
rwlbuis
PTAL.
4 years, 5 months ago (2016-07-24 18:11:26 UTC) #10
majidvp
Still lgtm On Sun, Jul 24, 2016, 2:11 PM <rob.buis@samsung.com> wrote: > PTAL. > > ...
4 years, 5 months ago (2016-07-24 18:23:29 UTC) #11
majidvp
Still lgtm On Sun, Jul 24, 2016, 2:11 PM <rob.buis@samsung.com> wrote: > PTAL. > > ...
4 years, 5 months ago (2016-07-24 18:23:29 UTC) #12
Mike West
LGTM 2, for what it's worth.
4 years, 4 months ago (2016-07-27 08:40:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161693003/60001
4 years, 4 months ago (2016-07-27 09:12:20 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-07-27 10:28:10 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 10:31:22 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cf2cd6b49ba5aed9c7229dda27c5c5d8db96fc41
Cr-Commit-Position: refs/heads/master@{#408087}

Powered by Google App Engine
This is Rietveld 408576698