scripts/slave/recipe_modules/chromium/api.py - Issue 2161673002: chromium.compile: set cwd to checkout for TARGET_CROS_BOARD builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 2161673002: chromium.compile: set cwd to checkout for TARGET_CROS_BOARD builds (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_ChromiumOS_amd64_generic_Compile.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium/api.py

diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py

index 9d010c949d8aea9482720f67aa92cd6ca595093d..85098978fd82e17e0a683a3d3e51945879c311b8 100644

--- a/scripts/slave/recipe_modules/chromium/api.py

+++ b/scripts/slave/recipe_modules/chromium/api.py

@@ -224,6 +224,7 @@ class ChromiumApi(recipe_api.RecipeApi):

if self.c.TARGET_CROS_BOARD:

# Wrap 'compile' through 'cros chrome-sdk'

kwargs['wrapper'] = self.get_cros_chrome_sdk_wrapper()

+ kwargs.setdefault('cwd', self.m.path['checkout'])

env = self.get_env()

env.update(kwargs.pop('env', {}))