Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2161633005: Converted Observatory nav-refresh element (Closed)

Created:
4 years, 5 months ago by cbernaschina
Modified:
4 years, 5 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed the loading of constant labels #

Patch Set 3 : Merged with master #

Patch Set 4 : Added missing } in shared.css #

Patch Set 5 : Final Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+320 lines, -54 lines) Patch
M runtime/observatory/lib/elements.dart View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/application.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/nav/refresh.dart View 1 chunk +92 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/nav/refresh_wrapper.dart View 1 1 chunk +78 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav_bar.dart View 1 chunk +0 lines, -25 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav_bar.html View 1 chunk +0 lines, -30 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/nav/refresh/element_test.dart View 1 chunk +122 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/nav/refresh/element_test.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
cbernaschina
4 years, 5 months ago (2016-07-18 22:21:13 UTC) #2
rmacnak
https://codereview.chromium.org/2161633005/diff/1/runtime/observatory/lib/src/elements/nav/refresh_wrapper.dart File runtime/observatory/lib/src/elements/nav/refresh_wrapper.dart (right): https://codereview.chromium.org/2161633005/diff/1/runtime/observatory/lib/src/elements/nav/refresh_wrapper.dart#newcode25 runtime/observatory/lib/src/elements/nav/refresh_wrapper.dart:25: } Some labels don't seem to make it here. ...
4 years, 5 months ago (2016-07-19 00:13:33 UTC) #3
cbernaschina
https://codereview.chromium.org/2161633005/diff/1/runtime/observatory/lib/src/elements/nav/refresh_wrapper.dart File runtime/observatory/lib/src/elements/nav/refresh_wrapper.dart (right): https://codereview.chromium.org/2161633005/diff/1/runtime/observatory/lib/src/elements/nav/refresh_wrapper.dart#newcode25 runtime/observatory/lib/src/elements/nav/refresh_wrapper.dart:25: } On 2016/07/19 00:13:33, rmacnak wrote: > Some labels ...
4 years, 5 months ago (2016-07-19 02:56:07 UTC) #4
cbernaschina
4 years, 5 months ago (2016-07-19 03:00:32 UTC) #5
Cutch
lgtm
4 years, 5 months ago (2016-07-19 14:16:42 UTC) #6
cbernaschina
4 years, 5 months ago (2016-07-19 18:22:00 UTC) #7
rmacnak
lgtm
4 years, 5 months ago (2016-07-19 22:17:44 UTC) #8
cbernaschina
4 years, 5 months ago (2016-07-19 22:20:19 UTC) #10
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
0cc589e10403f4ebe77ef65a4c40664a9b573fa1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698