Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 216163002: app_list_service_linux: Remove TODO about SetDidRunForNDayActiveStats. (Closed)

Created:
6 years, 9 months ago by Matt Giuca
Modified:
6 years, 9 months ago
Reviewers:
tapted
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

app_list_service_linux: Remove TODO about SetDidRunForNDayActiveStats. This is a Windows-specific stat tracking mechanism that uses the Windows registry and update mechanism. It isn't appropriate on Linux. We already have UMA stats for the App Launcher (including Linux); see app_list_service_impl.cc. BUG=357447 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260275

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/ui/views/app_list/linux/app_list_service_linux.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Matt Giuca
Quick cleanup; see CL description.
6 years, 9 months ago (2014-03-28 02:55:14 UTC) #1
tapted
lgtm!
6 years, 9 months ago (2014-03-28 03:09:07 UTC) #2
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 9 months ago (2014-03-28 03:09:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/216163002/1
6 years, 9 months ago (2014-03-28 03:10:40 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 03:50:19 UTC) #5
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) net_unittests, ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=136663
6 years, 9 months ago (2014-03-28 03:50:19 UTC) #6
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 9 months ago (2014-03-28 04:14:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/216163002/1
6 years, 9 months ago (2014-03-28 04:15:50 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 07:49:48 UTC) #9
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=136910
6 years, 9 months ago (2014-03-28 07:49:48 UTC) #10
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 9 months ago (2014-03-28 11:35:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/216163002/1
6 years, 9 months ago (2014-03-28 11:36:52 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 17:17:05 UTC) #13
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) sql_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=137447
6 years, 9 months ago (2014-03-28 17:17:05 UTC) #14
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 9 months ago (2014-03-28 21:00:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/216163002/1
6 years, 9 months ago (2014-03-28 21:01:32 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 21:05:20 UTC) #17
Message was sent while issue was closed. 
Change committed as 260275

Powered by Google App Engine
This is Rietveld 408576698