Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2161583003: [system health] Fix wpr archive names. (Closed)

Created:
4 years, 5 months ago by ulan
Modified:
4 years, 5 months ago
Reviewers:
nednguyen, petrcermak
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[system health] Fix wpr archive names. This patch renames browsing_*.wpr to memory_system_health_*.wpr so that all references in memory_system_health_*.json start with the same prefix 'memory_system_health'. For more context see https://codereview.chromium.org/2144073004/#msg21 BUG=589726 Committed: https://crrev.com/d7cfe1197875c332ba6116a0bd2d6c08c2235d84 Cr-Commit-Position: refs/heads/master@{#405998}

Patch Set 1 #

Patch Set 2 : Address comments #

Patch Set 3 : add json files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -220 lines) Patch
D tools/perf/page_sets/data/browsing_desktop_000.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/browsing_desktop_001.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/browsing_desktop_002.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/browsing_desktop_003.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/browsing_desktop_004.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/browsing_mobile_000.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/browsing_mobile_001.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/browsing_mobile_002.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/browsing_mobile_003.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/browsing_mobile_004.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/browsing_mobile_005.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/browsing_mobile_006.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/browsing_mobile_007.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/memory_system_health_desktop.json View 1 1 chunk +0 lines, -85 lines 0 comments Download
D tools/perf/page_sets/data/memory_system_health_desktop_000.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_desktop_001.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_desktop_002.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_desktop_003.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_desktop_004.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_desktop_005.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_desktop_006.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_desktop_007.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_desktop_008.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_desktop_009.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_desktop_010.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_desktop_011.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_desktop_012.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/memory_system_health_mobile.json View 1 1 chunk +0 lines, -94 lines 0 comments Download
D tools/perf/page_sets/data/memory_system_health_mobile_000.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_mobile_001.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_mobile_002.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_mobile_003.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_mobile_004.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_mobile_005.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_mobile_006.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_mobile_007.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_mobile_008.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_mobile_009.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_mobile_010.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_mobile_011.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_mobile_012.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/memory_system_health_mobile_013.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
A + tools/perf/page_sets/data/system_health_desktop.json View 1 2 4 chunks +18 lines, -18 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_desktop_000.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_desktop_001.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_desktop_002.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_desktop_003.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_desktop_004.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_desktop_005.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_desktop_006.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_desktop_007.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_desktop_008.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_desktop_009.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_desktop_010.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_desktop_011.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_desktop_012.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_desktop_013.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_desktop_014.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_desktop_015.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_desktop_016.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_desktop_017.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_mobile.json View 1 2 4 chunks +22 lines, -22 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_mobile_000.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_mobile_001.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_mobile_002.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_mobile_003.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_mobile_004.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_mobile_005.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_mobile_006.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_mobile_007.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_mobile_008.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_mobile_009.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_mobile_010.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_mobile_011.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_mobile_012.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_mobile_013.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_mobile_014.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_mobile_015.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_mobile_016.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_mobile_017.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_mobile_018.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_mobile_019.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_mobile_020.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/perf/page_sets/data/system_health_mobile_021.wpr.sha1 View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/perf/page_sets/system_health/system_health_stories.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (12 generated)
ulan
PTAL. I didn't upload the wpr files to cloud storage yet, but presubmit check did ...
4 years, 5 months ago (2016-07-18 13:46:47 UTC) #2
petrcermak
The stories actually have nothing to do with memory. Could you please rename them to ...
4 years, 5 months ago (2016-07-18 13:49:39 UTC) #4
nednguyen
On 2016/07/18 13:46:47, ulan wrote: > PTAL. > > I didn't upload the wpr files ...
4 years, 5 months ago (2016-07-18 13:49:43 UTC) #5
petrcermak
Also please add "BUG=589726".
4 years, 5 months ago (2016-07-18 13:50:15 UTC) #6
ulan
> The stories actually have nothing to do with memory. Could you please rename > ...
4 years, 5 months ago (2016-07-18 14:05:25 UTC) #8
ulan
> I am going to upload wpr files now. Actually, there is no need to ...
4 years, 5 months ago (2016-07-18 14:24:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161583003/40001
4 years, 5 months ago (2016-07-18 14:32:54 UTC) #16
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-18 14:32:56 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-18 15:34:49 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 15:41:14 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d7cfe1197875c332ba6116a0bd2d6c08c2235d84
Cr-Commit-Position: refs/heads/master@{#405998}

Powered by Google App Engine
This is Rietveld 408576698