Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2161573002: Revert of Calculate correct cull rect for SVG inline text boxes. (Closed)

Created:
4 years, 5 months ago by Benoit L
Modified:
4 years, 5 months ago
Reviewers:
pdr, wkorman
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Calculate correct cull rect for SVG inline text boxes. (patchset #4 id:60001 of https://codereview.chromium.org/2151323004/ ) Reason for revert: Broke WebKit Android (Nexus4). BUG=629023, 627233 Original issue's description: > Calculate correct cull rect for SVG inline text boxes. > > Cull rects were larger than needed when text was selected. > > Identified while investigating test failure of: > > svg/text/text-selection-align-06-b.svg > > as part of http://crrev.com/2073563002 for crbug.com/616600, though > fixing these did not actually fix any issues for that patch or bug. > > Reland of http://crrev.com/2137753002 with updated test to > approximate expected rects to allow for minor font metrics differences > across platforms. Notably, previous patch failed on Android Nexus 4 > due to 1 - 2 pixel deltas. > > BUG=627233 > TBR=pdr > > Committed: https://crrev.com/344d1d48097756a754766c75b9c49c756f85d20e > Cr-Commit-Position: refs/heads/master@{#405920} TBR=pdr@google.com,wkorman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/f33d0154201310ea6eeb515da696d2daab06791f Cr-Commit-Position: refs/heads/master@{#405977}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -139 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/DOMSelection.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainterTest.cpp View 1 chunk +0 lines, -136 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Benoit L
Created Revert of Calculate correct cull rect for SVG inline text boxes.
4 years, 5 months ago (2016-07-18 09:50:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161573002/1
4 years, 5 months ago (2016-07-18 09:52:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 11:41:31 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 11:43:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f33d0154201310ea6eeb515da696d2daab06791f
Cr-Commit-Position: refs/heads/master@{#405977}

Powered by Google App Engine
This is Rietveld 408576698