Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2161533003: Add makeSpecial calls to SkGpuDevice (Closed)

Created:
4 years, 5 months ago by robertphillips
Modified:
4 years, 5 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix test #

Patch Set 3 : Remove dead code #

Patch Set 4 : Nervous compilers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -5 lines) Patch
M include/core/SkDevice.h View 1 2 3 chunks +7 lines, -0 lines 0 comments Download
M src/core/SkDevice.cpp View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 1 chunk +5 lines, -3 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 chunks +42 lines, -2 lines 0 comments Download
A tests/DeviceTest.cpp View 1 2 3 1 chunk +124 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
robertphillips
Not quite ready yet - the unit test still needs work.
4 years, 5 months ago (2016-07-18 13:22:59 UTC) #4
reed1
lgtm
4 years, 5 months ago (2016-07-18 14:17:57 UTC) #5
reed1
I will merge this w/ https://codereview.chromium.org/2155063002/# after this lands
4 years, 5 months ago (2016-07-18 14:18:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161533003/60001
4 years, 5 months ago (2016-07-18 15:30:34 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 15:31:35 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/6451a0cea6007aff54565ec82e2f86cb1d32ecc7

Powered by Google App Engine
This is Rietveld 408576698