Invoke setup.exe to reenable updates when the update bubble is clicked.

Invoke setup.exe to reenable updates when the update bubble is clicked.

When Chrome detects it is out of date and the user clicks to reenable
updates, this will shell out to setup.exe, elevate if necessary and
perform the needed actions to reenable updates.

BUG=164681, 171271
TEST=Run chrome.exe --simulate-outdated-no-au and click on reenable updates while Omaha group policy to disable updates is applied.

[robertshield, 2014-03-28 17:20:35]

PTAL

[MAD, 2014-03-28 18:18:22]

LGTM with one question...

BYE
MAD

https://codereview.chromium.org/216153006/diff/1/chrome/browser/ui/views/outd...
File chrome/browser/ui/views/outdated_upgrade_bubble_view.cc (right):

https://codereview.chromium.org/216153006/diff/1/chrome/browser/ui/views/outd...
chrome/browser/ui/views/outdated_upgrade_bubble_view.cc:280:
base::Bind(&ReenableUpdates));
You were not able to Bind directly to
google_update::ElevateIfNeededToReenableUpdates()?

[robertshield, 2014-03-28 19:15:35]

Thanks!

https://codereview.chromium.org/216153006/diff/1/chrome/browser/ui/views/outd...
File chrome/browser/ui/views/outdated_upgrade_bubble_view.cc (right):

https://codereview.chromium.org/216153006/diff/1/chrome/browser/ui/views/outd...
chrome/browser/ui/views/outdated_upgrade_bubble_view.cc:280:
base::Bind(&ReenableUpdates));
On 2014/03/28 18:18:23, MAD wrote:
> You were not able to Bind directly to
> google_update::ElevateIfNeededToReenableUpdates()?

Done.

[grt (UTC plus 2), 2014-03-28 21:22:21]

https://codereview.chromium.org/216153006/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/outdated_upgrade_bubble_view.cc (right):

https://codereview.chromium.org/216153006/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/outdated_upgrade_bubble_view.cc:274: // Re-enable
updates by shelling out to setup.exe on the file thread.
is the blocking pool not a better place for this?

https://codereview.chromium.org/216153006/diff/20001/chrome/installer/util/go...
File chrome/installer/util/google_update_util.cc (right):

https://codereview.chromium.org/216153006/diff/20001/chrome/installer/util/go...
chrome/installer/util/google_update_util.cc:226: base::FilePath chrome_exe;
i think you can replace a bunch of this code with something like:
  base::FilePath setup_path;
  ProductState chrome_state;
  if (chrome_state.Initialize(!IsPerUserInstall(...),
BrowserDistribution::CHROME_BROWSER))
    setup_path = chrome_state.GetSetupPath();
  if (setup_path.empty())
    handle the error case

also, i think it makes sense to add --multi-install here if
chrome_state.is_multi_install() so that setup doesn't need to try to figure that
stuff out.

[grt (UTC plus 2), 2014-03-31 13:56:32]

Closed issue since this landed under https://codereview.chromium.org/217533005/.