third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp - Issue 2161493002: [DevTools] Pass client initiating DevToolsAgentHost::inspectElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 2161493002: [DevTools] Pass client initiating DevToolsAgentHost::inspectElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/devtools_messages.h ('K') | « third_party/WebKit/Source/web/WebDevToolsAgentImpl.h ('k') | third_party/WebKit/public/web/WebDevToolsAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

index 2d1a7c0096454177b021c727ede7331c80771dda..0e305d25285d1350dd847370ab8a5f5e87daa3e7 100644

--- a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

+++ b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

@@ -549,9 +549,9 @@ void WebDevToolsAgentImpl::dispatchMessageFromFrontend(int sessionId, const Stri

m_session->dispatchProtocolMessage(method, message);

}

-void WebDevToolsAgentImpl::inspectElementAt(const WebPoint& pointInRootFrame)

+void WebDevToolsAgentImpl::inspectElementAt(int sessionId, const WebPoint& pointInRootFrame)

{

- if (!m_domAgent)

+ if (!m_domAgent || !m_session || m_session->sessionId() != sessionId)

return;

HitTestRequest::HitTestRequestType hitType = HitTestRequest::Move | HitTestRequest::ReadOnly | HitTestRequest::AllowChildFrameContent;

HitTestRequest request(hitType);

« content/common/devtools_messages.h ('K') | « third_party/WebKit/Source/web/WebDevToolsAgentImpl.h ('k') | third_party/WebKit/public/web/WebDevToolsAgent.h » ('j') | no next file with comments »