[ios] Retry injection of windowID if it has failed.

[ios] Retry injection of windowID if it has failed.

windowID injection will fail if WKUserScript has not been injected yet
and __crWeb object is not present. windowID injection is critical for
many features to function and on failure it should be retried.

So far injection failure has been observed only in KIF test.

BUG=628316
Committed: https://crrev.com/f03b448cc05e2201d6a3d05ef8aa770547b20bab
Cr-Commit-Position: refs/heads/master@{#406146}

[Eugene But (OOO till 7-30), 2016-07-16 01:39:13]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[Eugene But (OOO till 7-30), 2016-07-16 01:39:22]

eugenebut@chromium.org changed reviewers:
+ kkhorimoto@chromium.org

[commit-bot: I haz the power, 2016-07-16 01:39:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-16 02:11:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-16 02:11:46]

Dry run: This issue passed the CQ dry run.

[kkhorimoto, 2016-07-18 18:29:36]

https://codereview.chromium.org/2161463002/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2161463002/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:2533: // This can happen if
WKUserScript has not been injected yet.
There are other reasons why we can get an exception right?  If this is failing
for a different reason, wouldn't this cause an infinite loop of injection
attempts?

[Eugene But (OOO till 7-30), 2016-07-18 18:43:09]

https://codereview.chromium.org/2161463002/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2161463002/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:2533: // This can happen if
WKUserScript has not been injected yet.
On 2016/07/18 18:29:36, kkhorimoto_ wrote:
> There are other reasons why we can get an exception right?  If this is failing
> for a different reason, wouldn't this cause an infinite loop of injection
> attempts?
The other reason is a bug inside window_id.js, but in this case a bunch of our
integration tests will fail and we will fix the script. So I think than infinite
loop will not happen in practice. Do you want me to explicitly document this in
the comments?

[kkhorimoto, 2016-07-18 22:58:53]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2016-07-18 22:58:54]

lgtm

[commit-bot: I haz the power, 2016-07-18 22:59:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 23:44:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-18 23:47:51]

Description was changed from

==========
[ios] Retry injection of windowID if it has failed.

windowID injection will fail if WKUserScript has not been injected yet
and __crWeb object is not present. windowID injection is critical for
many features to function and on failure it should be retried.

So far injection failure has been observed only in KIF test.

BUG=628316
==========

to

==========
[ios] Retry injection of windowID if it has failed.

windowID injection will fail if WKUserScript has not been injected yet
and __crWeb object is not present. windowID injection is critical for
many features to function and on failure it should be retried.

So far injection failure has been observed only in KIF test.

BUG=628316

Committed: https://crrev.com/f03b448cc05e2201d6a3d05ef8aa770547b20bab
Cr-Commit-Position: refs/heads/master@{#406146}
==========

[commit-bot: I haz the power, 2016-07-18 23:47:52]

Patchset 1 (id:??) landed as
https://crrev.com/f03b448cc05e2201d6a3d05ef8aa770547b20bab
Cr-Commit-Position: refs/heads/master@{#406146}