Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2161423002: Switch on use_new_wrapper_types mode for url/mojo/ and components/web_cache/ (Closed)

Created:
4 years, 5 months ago by leonhsl(Using Gerrit)
Modified:
4 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch on use_new_wrapper_types mode for url/mojo/ and components/web_cache/ BUG=624136 Committed: https://crrev.com/807a5ba700a67dece2b2864c8889f30892ba3128 Cr-Commit-Position: refs/heads/master@{#406744}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -21 lines) Patch
M components/web_cache.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M components/web_cache/public/interfaces/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M url/mojo/BUILD.gn View 3 chunks +0 lines, -6 lines 0 comments Download
M url/mojo/origin_struct_traits.h View 1 chunk +2 lines, -6 lines 0 comments Download
M url/url.gyp View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
leonhsl(Using Gerrit)
Would you PTAL at this? Thanks. tsepez: OWNER review for url/mojo/origin_struct_traits.h mkwst: OWNER review for ...
4 years, 5 months ago (2016-07-20 07:56:41 UTC) #6
Mike West
//url LGTM, assuming that this is the right thing to do from Mojo's perspective. I'll ...
4 years, 5 months ago (2016-07-20 08:13:23 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-20 11:09:27 UTC) #9
yzshen1
lgtm
4 years, 5 months ago (2016-07-20 15:59:21 UTC) #10
Tom Sepez
traits LGTM
4 years, 5 months ago (2016-07-20 16:57:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161423002/1
4 years, 5 months ago (2016-07-21 02:46:44 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 02:49:50 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 02:51:53 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/807a5ba700a67dece2b2864c8889f30892ba3128
Cr-Commit-Position: refs/heads/master@{#406744}

Powered by Google App Engine
This is Rietveld 408576698