Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2161413002: Adjust whitespace to make tests oblivious to --harmony-function-tostring (Closed)

Created:
4 years, 5 months ago by jwolfe
Modified:
4 years, 5 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Adjust whitespace to make tests oblivious to --harmony-function-tostring See discussion in https://codereview.chromium.org/2156303002/#msg8 With the new --harmony-function-tostring behavior, these tests would fail without this change. This change makes the tests pass regardless of whether or not --harmony-function-tostring is used. All of these changes are simply inserting a space after the "function" keyword to match the current function toString behavior. When --harmony-function-tostring is enabled, the toString behavior matches the spacing used in the function declaration. With the declaration matching the current formatting, the toString behavior becomes unaffected by --harmony-function-tostring. BUG=v8:4958 LOG=n Committed: https://crrev.com/3cfd80d6a254357f90d907c89c4d16857cb06d0e Cr-Commit-Position: refs/heads/master@{#37959}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -203 lines) Patch
M test/cctest/compiler/test-run-jscalls.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/function-name.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/harmony/async-await-basic.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mirror-object.js View 1 chunk +4 lines, -4 lines 0 comments Download
M test/webkit/dfg-redundant-load-of-captured-variable-proven-constant.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/webkit/dfg-resolve-global-specific-dictionary.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/basic-strict-mode.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/basic-strict-mode-expected.txt View 4 chunks +56 lines, -56 lines 0 comments Download
M test/webkit/fast/js/function-toString-semicolon-insertion.js View 1 chunk +5 lines, -5 lines 0 comments Download
M test/webkit/fast/js/function-toString-semicolon-insertion-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M test/webkit/fast/js/kde/lval-exceptions.js View 1 chunk +7 lines, -7 lines 0 comments Download
M test/webkit/resources/JSON-stringify.js View 7 chunks +116 lines, -116 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
jwolfe
4 years, 5 months ago (2016-07-20 06:17:00 UTC) #3
Dan Ehrenberg
lgtm
4 years, 5 months ago (2016-07-21 23:48:24 UTC) #4
Dan Ehrenberg
You may have to make a similar change within the Blink tests
4 years, 5 months ago (2016-07-21 23:48:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161413002/1
4 years, 5 months ago (2016-07-21 23:56:57 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 00:18:09 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 00:18:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cfd80d6a254357f90d907c89c4d16857cb06d0e
Cr-Commit-Position: refs/heads/master@{#37959}

Powered by Google App Engine
This is Rietveld 408576698