Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: content/browser/frame_host/navigation_controller_impl.h

Issue 2161393002: Clone children of FrameNavigationEntries for in-page navigations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
277 // changed, or false if not. 277 // changed, or false if not.
278 // 278 //
279 // The NewPage and NewSubframe functions take in |replace_entry| to pass to 279 // The NewPage and NewSubframe functions take in |replace_entry| to pass to
280 // InsertOrReplaceEntry, in case the newly created NavigationEntry is meant to 280 // InsertOrReplaceEntry, in case the newly created NavigationEntry is meant to
281 // replace the current one (e.g., for location.replace or successful loads 281 // replace the current one (e.g., for location.replace or successful loads
282 // after net errors), in contrast to updating a NavigationEntry in place 282 // after net errors), in contrast to updating a NavigationEntry in place
283 // (e.g., for history.replaceState). 283 // (e.g., for history.replaceState).
284 void RendererDidNavigateToNewPage( 284 void RendererDidNavigateToNewPage(
285 RenderFrameHostImpl* rfh, 285 RenderFrameHostImpl* rfh,
286 const FrameHostMsg_DidCommitProvisionalLoad_Params& params, 286 const FrameHostMsg_DidCommitProvisionalLoad_Params& params,
287 bool is_in_page,
287 bool replace_entry); 288 bool replace_entry);
288 void RendererDidNavigateToExistingPage( 289 void RendererDidNavigateToExistingPage(
289 RenderFrameHostImpl* rfh, 290 RenderFrameHostImpl* rfh,
290 const FrameHostMsg_DidCommitProvisionalLoad_Params& params); 291 const FrameHostMsg_DidCommitProvisionalLoad_Params& params);
291 void RendererDidNavigateToSamePage( 292 void RendererDidNavigateToSamePage(
292 RenderFrameHostImpl* rfh, 293 RenderFrameHostImpl* rfh,
293 const FrameHostMsg_DidCommitProvisionalLoad_Params& params); 294 const FrameHostMsg_DidCommitProvisionalLoad_Params& params);
294 void RendererDidNavigateNewSubframe( 295 void RendererDidNavigateNewSubframe(
295 RenderFrameHostImpl* rfh, 296 RenderFrameHostImpl* rfh,
296 const FrameHostMsg_DidCommitProvisionalLoad_Params& params, 297 const FrameHostMsg_DidCommitProvisionalLoad_Params& params,
298 bool is_in_page,
297 bool replace_entry); 299 bool replace_entry);
298 bool RendererDidNavigateAutoSubframe( 300 bool RendererDidNavigateAutoSubframe(
299 RenderFrameHostImpl* rfh, 301 RenderFrameHostImpl* rfh,
300 const FrameHostMsg_DidCommitProvisionalLoad_Params& params); 302 const FrameHostMsg_DidCommitProvisionalLoad_Params& params);
301 303
302 // Helper function for code shared between Reload() and 304 // Helper function for code shared between Reload() and
303 // ReloadBypassingCache(). 305 // ReloadBypassingCache().
304 void ReloadInternal(bool check_for_repost, ReloadType reload_type); 306 void ReloadInternal(bool check_for_repost, ReloadType reload_type);
305 307
306 // Actually issues the navigation held in pending_entry. 308 // Actually issues the navigation held in pending_entry.
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 TimeSmoother time_smoother_; 451 TimeSmoother time_smoother_;
450 452
451 std::unique_ptr<NavigationEntryScreenshotManager> screenshot_manager_; 453 std::unique_ptr<NavigationEntryScreenshotManager> screenshot_manager_;
452 454
453 DISALLOW_COPY_AND_ASSIGN(NavigationControllerImpl); 455 DISALLOW_COPY_AND_ASSIGN(NavigationControllerImpl);
454 }; 456 };
455 457
456 } // namespace content 458 } // namespace content
457 459
458 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_ 460 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698