Make FrameCaret to retrieve caret position from SelectionEditor

Make FrameCaret to retrieve caret position from SelectionEditor

This patch makes |FrameCaret| to use caret position from |SelectionEditor|
instead of holding caret position in |FrameCaret| to get rid of code of
maintaining caret position between |FrameCaret| and |SelectionEditor|
synchronize for improving code health.

The root cause of crbug.com/628520 is missing synchronization code in
|FrameSelection::updateIfNeeded()|. This patch is simpler than adding
synchronization code in |FrameSelection::updateIfNeeded()|.

BUG=628520
TEST=run_webkit_unit_tests --gtest_filter=FrameSelectionTest.updateIfNeededAndFrameCaret

Committed: https://crrev.com/ec7e0ef4bfdb8f0cd0c9a45ed9d45755d9a3c684
Cr-Commit-Position: refs/heads/master@{#406792}

[yosin_UTC9, 2016-07-20 04:33:59]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 04:34:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 08:12:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 08:12:43]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-07-20 08:27:32]

Description was changed from

==========
2016-07-20T13:32:26

BUG=
==========

to

==========
Make FrameCaret to retrieve caret position from SelectionEditor

This patch makes |FrameCaret| to use caret position from |SelectionEditor|
instead of holding caret position in |FrameCaret| to get rid of code of
maintaining caret position between |FrameCaret| and |SelectionEditor|
synchronize for improving code health.

The root cause of crbug.com/628520 is missing synchronization code in
|FrameSelection::updateIfNeeded()|. This patch is simpler than adding
synchronization code in |FrameSelection::updateIfNeeded()|.

BUG=628520
TEST=run_webkit_unit_tests
--gtest_filter=FrameSelectionTest.updateIfNeededAndFrameCaret
==========

[yosin_UTC9, 2016-07-20 08:27:43]

yosin@chromium.org changed reviewers:
+ yoichio@chromium.org

[yosin_UTC9, 2016-07-20 08:27:44]

PTAL

[yoichio, 2016-07-20 09:10:06]

https://codereview.chromium.org/2161373002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp (right):

https://codereview.chromium.org/2161373002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp:287:
setSelection(VisibleSelection(Position(sample, 0)));
Confirm selection().start() and caretPosition().position() is not null
before and after body is removed.

[yosin_UTC9, 2016-07-20 09:27:02]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 09:27:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-07-20 09:27:33]

PTAL

Update test case.

https://codereview.chromium.org/2161373002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp (right):

https://codereview.chromium.org/2161373002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp:287:
setSelection(VisibleSelection(Position(sample, 0)));
On 2016/07/20 at 09:10:06, yoichio wrote:
> Confirm selection().start() and caretPosition().position() is not null
> before and after body is removed.

Done.

[commit-bot: I haz the power, 2016-07-20 11:34:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 11:34:34]

Dry run: This issue passed the CQ dry run.

[yoichio, 2016-07-21 01:51:57]

https://codereview.chromium.org/2161373002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp (right):

https://codereview.chromium.org/2161373002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp:288:
EXPECT_EQ(Position(document().body(), 0), selection().start());
Add EXPECT_EQ( selection().start()), caretPosition().position())).

https://codereview.chromium.org/2161373002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp:292:
EXPECT_EQ(Position(document().documentElement(), 1), selection().start());
ditto.

https://codereview.chromium.org/2161373002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp:300: << "caret
position and selection.start should be same.";
EXPECT_EQ( selection().start()), caretPosition().position())) instead?

[yosin_UTC9, 2016-07-21 02:26:49]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 02:27:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-07-21 02:27:42]

PTAL

Update a test case to add EXPEC_EQ(selection().start(),
caretPosition().position());

https://codereview.chromium.org/2161373002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp (right):

https://codereview.chromium.org/2161373002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp:288:
EXPECT_EQ(Position(document().body(), 0), selection().start());
On 2016/07/21 at 01:51:57, yoichio wrote:
> Add EXPECT_EQ( selection().start()), caretPosition().position())).

Done

https://codereview.chromium.org/2161373002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp:292:
EXPECT_EQ(Position(document().documentElement(), 1), selection().start());
On 2016/07/21 at 01:51:57, yoichio wrote:
> ditto.

Done.

https://codereview.chromium.org/2161373002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp:300: << "caret
position and selection.start should be same.";
On 2016/07/21 at 01:51:57, yoichio wrote:
> EXPECT_EQ( selection().start()), caretPosition().position())) instead?

Done.

[commit-bot: I haz the power, 2016-07-21 03:53:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 03:53:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yoichio, 2016-07-21 04:52:46]

lgtm

[yosin_UTC9, 2016-07-21 05:37:14]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-07-21 05:37:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 07:07:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-21 07:10:45]

Description was changed from

==========
Make FrameCaret to retrieve caret position from SelectionEditor

This patch makes |FrameCaret| to use caret position from |SelectionEditor|
instead of holding caret position in |FrameCaret| to get rid of code of
maintaining caret position between |FrameCaret| and |SelectionEditor|
synchronize for improving code health.

The root cause of crbug.com/628520 is missing synchronization code in
|FrameSelection::updateIfNeeded()|. This patch is simpler than adding
synchronization code in |FrameSelection::updateIfNeeded()|.

BUG=628520
TEST=run_webkit_unit_tests
--gtest_filter=FrameSelectionTest.updateIfNeededAndFrameCaret
==========

to

==========
Make FrameCaret to retrieve caret position from SelectionEditor

This patch makes |FrameCaret| to use caret position from |SelectionEditor|
instead of holding caret position in |FrameCaret| to get rid of code of
maintaining caret position between |FrameCaret| and |SelectionEditor|
synchronize for improving code health.

The root cause of crbug.com/628520 is missing synchronization code in
|FrameSelection::updateIfNeeded()|. This patch is simpler than adding
synchronization code in |FrameSelection::updateIfNeeded()|.

BUG=628520
TEST=run_webkit_unit_tests
--gtest_filter=FrameSelectionTest.updateIfNeededAndFrameCaret

Committed: https://crrev.com/ec7e0ef4bfdb8f0cd0c9a45ed9d45755d9a3c684
Cr-Commit-Position: refs/heads/master@{#406792}
==========

[commit-bot: I haz the power, 2016-07-21 07:10:46]

Patchset 3 (id:??) landed as
https://crrev.com/ec7e0ef4bfdb8f0cd0c9a45ed9d45755d9a3c684
Cr-Commit-Position: refs/heads/master@{#406792}