Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1963)

Issue 2161363006: Settings People Revamp: Tweak Cancel button on Disconnect dialog. (Closed)

Created:
4 years, 5 months ago by tommycli
Modified:
4 years, 5 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings People Revamp: Tweak Cancel button on Disconnect dialog. Adds a missing class to properly space the Cancel button on the Disconnect dialog in the People section. BUG=630189 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0e6a36ee2555f7d11ac948d6af0e1f68b16ff81f Cr-Commit-Position: refs/heads/master@{#407232}

Patch Set 1 #

Patch Set 2 : update credit card dialog #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.html View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
tommycli
dpapad: PTAL, thx for reporting bug
4 years, 5 months ago (2016-07-21 21:47:04 UTC) #3
dpapad
On 2016/07/21 at 21:47:04, tommycli wrote: > dpapad: PTAL, thx for reporting bug I am ...
4 years, 5 months ago (2016-07-21 22:04:18 UTC) #4
tommycli
On 2016/07/21 22:04:18, dpapad wrote: > On 2016/07/21 at 21:47:04, tommycli wrote: > > dpapad: ...
4 years, 5 months ago (2016-07-22 18:20:24 UTC) #5
dpapad
lgtm
4 years, 5 months ago (2016-07-22 18:21:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161363006/20001
4 years, 5 months ago (2016-07-22 18:29:20 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-22 19:40:05 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 19:41:15 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0e6a36ee2555f7d11ac948d6af0e1f68b16ff81f
Cr-Commit-Position: refs/heads/master@{#407232}

Powered by Google App Engine
This is Rietveld 408576698