Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2161363002: Refactoring of nav-notify (Closed)

Created:
4 years, 5 months ago by cbernaschina
Modified:
4 years, 5 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed duplicated nav-notify tag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -10 lines) Patch
M runtime/observatory/lib/src/elements/class_tree.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_view.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/code_view.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/context_view.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile.html View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.html View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/error_view.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/field_view.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/flag_list.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/function_view.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/general_error.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_map.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_profile.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_snapshot.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/icdata_view.html View 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_view.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/instructions_view.html View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/io_view.html View 1 11 chunks +11 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_reconnect.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_view.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/json_view.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/library_view.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/logging.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/megamorphiccache_view.html View 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/metrics.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav_bar.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/nav_bar.html View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/object_view.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/objectpool_view.html View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/objectstore_view.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/persistent_handles.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/ports.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_view.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/timeline_page.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_connect.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_view.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
cbernaschina
4 years, 5 months ago (2016-07-20 03:28:50 UTC) #2
Cutch
lgtm
4 years, 5 months ago (2016-07-20 13:48:38 UTC) #3
rmacnak
lgtm w/c https://chromiumcodereview.appspot.com/2161363002/diff/1/runtime/observatory/lib/src/elements/io_view.html File runtime/observatory/lib/src/elements/io_view.html (right): https://chromiumcodereview.appspot.com/2161363002/diff/1/runtime/observatory/lib/src/elements/io_view.html#newcode94 runtime/observatory/lib/src/elements/io_view.html:94: <nav-notify notifications="{{ app.notifications }}"></nav-notify> Just one please.
4 years, 5 months ago (2016-07-21 23:17:59 UTC) #4
cbernaschina
https://codereview.chromium.org/2161363002/diff/1/runtime/observatory/lib/src/elements/io_view.html File runtime/observatory/lib/src/elements/io_view.html (right): https://codereview.chromium.org/2161363002/diff/1/runtime/observatory/lib/src/elements/io_view.html#newcode94 runtime/observatory/lib/src/elements/io_view.html:94: <nav-notify notifications="{{ app.notifications }}"></nav-notify> On 2016/07/21 23:17:58, rmacnak wrote: ...
4 years, 5 months ago (2016-07-21 23:20:45 UTC) #5
cbernaschina
4 years, 5 months ago (2016-07-21 23:22:00 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
b04ecef38bc92ed3f216fb4f1e63094fe51b48e8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698