Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2161333002: MD Settings: Cleanup, remove non existing item-icon property from <iron-icon>. (Closed)

Created:
4 years, 5 months ago by dpapad
Modified:
4 years, 5 months ago
Reviewers:
michaelpg
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Cleanup, remove non existing item-icon property from <iron-icon>. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f1f96a7ee42c598515732817fb1dc88f3727fb61 Cr-Commit-Position: refs/heads/master@{#406683}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M chrome/browser/resources/settings/site_settings/site_details_permission.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/site_settings_page/site_settings_page.html View 13 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
dpapad
@michaelpg: I could not find any references to an "item-icon" property for <iron-icon>. I think ...
4 years, 5 months ago (2016-07-19 23:27:54 UTC) #5
dpapad
Friendly ping.
4 years, 5 months ago (2016-07-20 19:14:59 UTC) #8
michaelpg
lgtm
4 years, 5 months ago (2016-07-20 19:47:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161333002/1
4 years, 5 months ago (2016-07-20 21:22:19 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 21:59:38 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 22:02:07 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1f96a7ee42c598515732817fb1dc88f3727fb61
Cr-Commit-Position: refs/heads/master@{#406683}

Powered by Google App Engine
This is Rietveld 408576698