Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc

Issue 216133002: Revert of Allows menu host windows to be enumerated in DragTargetWindowFinder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc
diff --git a/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc b/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc
index c56a3ce0e0d489825f8afe225d0b50ed9fbd7444..1147770bd5487a44bd8dad100d8ec9108271da03 100644
--- a/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc
+++ b/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc
@@ -64,7 +64,6 @@
"XdndStatus",
"XdndTypeList",
ui::Clipboard::kMimeTypeText,
- "_NET_WM_WINDOW_TYPE_MENU",
NULL
};
@@ -81,11 +80,9 @@
class DragTargetWindowFinder : public ui::EnumerateWindowsDelegate {
public:
DragTargetWindowFinder(XID ignored_icon_window,
- Atom menu_type_atom,
gfx::Point screen_loc)
: ignored_icon_window_(ignored_icon_window),
output_window_(None),
- menu_type_atom_(menu_type_atom),
screen_loc_(screen_loc) {
ui::EnumerateTopLevelWindows(this);
}
@@ -105,10 +102,7 @@
if (!ui::WindowContainsPoint(window, screen_loc_))
return false;
- int value = 0;
- if (ui::PropertyExists(window, "WM_STATE") ||
- (ui::GetIntProperty(window, "_NET_WM_WINDOW_TYPE", &value) &&
- static_cast<Atom>(value) == menu_type_atom_)) {
+ if (ui::PropertyExists(window, "WM_STATE")) {
output_window_ = window;
return true;
}
@@ -119,7 +113,6 @@
private:
XID ignored_icon_window_;
XID output_window_;
- const Atom menu_type_atom_;
gfx::Point screen_loc_;
DISALLOW_COPY_AND_ASSIGN(DragTargetWindowFinder);
@@ -130,9 +123,8 @@
// |mouse_window|. If there's a Xdnd aware window, it will be returned in
// |dest_window|.
void FindWindowFor(const gfx::Point& screen_point,
- ::Window* mouse_window, ::Window* dest_window,
- Atom menu_type_atom) {
- DragTargetWindowFinder finder(None, menu_type_atom, screen_point);
+ ::Window* mouse_window, ::Window* dest_window) {
+ DragTargetWindowFinder finder(None, screen_point);
*mouse_window = finder.window();
*dest_window = None;
@@ -442,10 +434,6 @@
DesktopDragDropClientAuraX11::~DesktopDragDropClientAuraX11() {
g_live_client_map.Get().erase(xwindow_);
- // Make sure that all observers are unregistered from source and target
- // windows. This may be necessary when the parent native widget gets destroyed
- // while a drag operation is in progress.
- NotifyDragLeave();
}
// static
@@ -708,8 +696,7 @@
// Find the current window the cursor is over.
::Window mouse_window = None;
::Window dest_window = None;
- FindWindowFor(screen_point, &mouse_window, &dest_window,
- atom_cache_.GetAtom("_NET_WM_WINDOW_TYPE_MENU"));
+ FindWindowFor(screen_point, &mouse_window, &dest_window);
if (source_current_window_ != dest_window) {
if (source_current_window_ != None)
« no previous file with comments | « ui/views/corewm/desktop_capture_controller_unittest.cc ('k') | ui/views/widget/desktop_aura/x11_desktop_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698