Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 216133002: Revert of Allows menu host windows to be enumerated in DragTargetWindowFinder (Closed)

Created:
6 years, 9 months ago by calamity
Modified:
6 years, 9 months ago
CC:
chromium-reviews, tfarina, ben+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Allows menu host windows to be enumerated in DragTargetWindowFinder (https://codereview.chromium.org/196213004/) Reason for revert: Seems to have broken views_unittests on the Linux builder. Original issue's description: > Allows menu host windows to be enumerated in DragTargetWindowFinder. > We create a cache that holds all XIDs of the menu windows that get created in X. The menus are evaluated for being drop targets before enumerating other windows. The menu XIDs cache gets updated in a root X11DesktopHandler when any menu (and Chrome menu in particular) gets created. > > TBR(sky) for OWNERS in ui/base/ui_base.gyp. > > BUG=349154, 349156, 344747 > TBR=sky > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260046 TBR=sadrul@chromium.org,erg@chromium.org,varkha@chromium.org NOTREECHECKS=true NOTRY=true BUG=349154, 349156, 344747 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260062

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -146 lines) Patch
M ui/base/ui_base.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/base/x/x11_menu_list.h View 1 chunk +0 lines, -48 lines 0 comments Download
D ui/base/x/x11_menu_list.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M ui/base/x/x11_util.cc View 5 chunks +2 lines, -14 lines 0 comments Download
M ui/views/corewm/desktop_capture_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc View 7 chunks +4 lines, -17 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_handler.cc View 2 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
calamity
Created Revert of Allows menu host windows to be enumerated in DragTargetWindowFinder
6 years, 9 months ago (2014-03-28 02:28:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/216133002/1
6 years, 9 months ago (2014-03-28 02:29:53 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 02:31:51 UTC) #3
Message was sent while issue was closed.
Change committed as 260062

Powered by Google App Engine
This is Rietveld 408576698