cc: Make LayerTreeHostImpl unittests use a delegating output surface.

cc/test/test_context_provider.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/test/test_context_provider.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <set>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/logging.h"
+#include "base/memory/ptr_util.h"
 #include "cc/test/test_gles2_interface.h"
 #include "cc/test/test_web_graphics_context_3d.h"
 #include "third_party/skia/include/gpu/GrContext.h"
 #include "third_party/skia/include/gpu/gl/GrGLInterface.h"
 
 namespace cc {
 
 // static
 scoped_refptr<TestContextProvider> TestContextProvider::Create() {
   return Create(TestWebGraphicsContext3D::Create());
 }
 
 // static
 scoped_refptr<TestContextProvider> TestContextProvider::CreateWorker() {
   scoped_refptr<TestContextProvider> worker_context_provider =
       Create(TestWebGraphicsContext3D::Create());
   // Worker contexts are bound to the thread they are created on.
   if (!worker_context_provider->BindToCurrentThread())
     return nullptr;
   return worker_context_provider;
 }
 
 // static
 scoped_refptr<TestContextProvider> TestContextProvider::Create(
     std::unique_ptr<TestWebGraphicsContext3D> context) {
+  DCHECK(context);

[vmpstr, 2016/07/20 01:11:22]

We don't usually

DCHECK(foo);
if (!foo)
 ...

do we?

[danakj, 2016/07/20 18:57:41]

No, I was fishing and left that in. I'll remove the if()!

   if (!context)
-    return NULL;
-  return new TestContextProvider(std::move(context));
+    return nullptr;
+  return new TestContextProvider(base::MakeUnique<TestGLES2Interface>(),
+                                 std::move(context));
+}
+
+// static
+scoped_refptr<TestContextProvider> TestContextProvider::Create(
+    std::unique_ptr<TestGLES2Interface> gl) {
+  DCHECK(gl);
+  return new TestContextProvider(std::move(gl),
+                                 TestWebGraphicsContext3D::Create());
 }
 
 TestContextProvider::TestContextProvider(
+    std::unique_ptr<TestGLES2Interface> gl,
     std::unique_ptr<TestWebGraphicsContext3D> context)
     : context3d_(std::move(context)),
-      context_gl_(new TestGLES2Interface(context3d_.get())),
+      context_gl_(std::move(gl)),
       bound_(false),
       weak_ptr_factory_(this) {
   DCHECK(main_thread_checker_.CalledOnValidThread());
   DCHECK(context3d_);
+  DCHECK(context_gl_);
   context_thread_checker_.DetachFromThread();
+  context_gl_->set_test_context(context3d_.get());
   context3d_->set_test_support(&support_);
 }
 
 TestContextProvider::~TestContextProvider() {
   DCHECK(main_thread_checker_.CalledOnValidThread() ||
          context_thread_checker_.CalledOnValidThread());
 }
 
 bool TestContextProvider::BindToCurrentThread() {
   // This is called on the thread the context will be used.
@@ skipping 90 matching lines @@
 }
 
 void TestContextProvider::SetLostContextCallback(
     const LostContextCallback& cb) {
   DCHECK(context_thread_checker_.CalledOnValidThread());
   DCHECK(lost_context_callback_.is_null() || cb.is_null());
   lost_context_callback_ = cb;
 }
 
 }  // namespace cc