Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: third_party/WebKit/Source/core/observer/ResizeObserver.cpp

Issue 2161313002: ResizeObserver implementation, part 2: lifetime (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR fixes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/observer/ResizeObserver.cpp
diff --git a/third_party/WebKit/Source/core/observer/ResizeObserver.cpp b/third_party/WebKit/Source/core/observer/ResizeObserver.cpp
index 599bcb388a3192e1d744c3e224d0e9fe0725d2ab..838daca88bc1dc6dca768dfbe4563b65c6920753 100644
--- a/third_party/WebKit/Source/core/observer/ResizeObserver.cpp
+++ b/third_party/WebKit/Source/core/observer/ResizeObserver.cpp
@@ -5,8 +5,9 @@
#include "core/observer/ResizeObserver.h"
#include "core/dom/Element.h"
+#include "core/observer/ResizeObservation.h"
#include "core/observer/ResizeObserverCallback.h"
-#include "core/observer/ResizeObserverEntry.h"
+#include "core/observer/ResizeObserverController.h"
namespace blink {
@@ -16,7 +17,10 @@ ResizeObserver* ResizeObserver::create(Document& document, ResizeObserverCallbac
}
ResizeObserver::ResizeObserver(ResizeObserverCallback* callback, Document& document)
+ : m_callback(callback)
{
+ m_controller = &document.ensureResizeObserverController();
+ m_controller->addObserver(*this);
}
void ResizeObserver::observe(Element* target)
@@ -33,6 +37,9 @@ void ResizeObserver::disconnect()
DEFINE_TRACE(ResizeObserver)
{
+ visitor->trace(m_callback);
+ visitor->trace(m_observations);
+ visitor->trace(m_controller);
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698