ResizeObserver implementation, part 2: lifetime

third_party/WebKit/Source/core/observer/ResizeObserver.h

Index: third_party/WebKit/Source/core/observer/ResizeObserver.h
diff --git a/third_party/WebKit/Source/core/observer/ResizeObserver.h b/third_party/WebKit/Source/core/observer/ResizeObserver.h
index 29ab47f12d3ca3155ac1700211e4fd9b9934f6a0..4bb112bcade48c28d7f65230395ba9dd090715de 100644
--- a/third_party/WebKit/Source/core/observer/ResizeObserver.h
+++ b/third_party/WebKit/Source/core/observer/ResizeObserver.h
@@ -13,7 +13,8 @@ namespace blink {
 class Document;
 class Element;
 class ResizeObserverCallback;
-class ResizeObserverEntry;
+class ResizeObserverController;
+class ResizeObservation;
 
 // ResizeObserver represents ResizeObserver javascript api:
 // https://github.com/WICG/ResizeObserver/
@@ -25,7 +26,6 @@ public:
 
     virtual ~ResizeObserver() {};
 
-
     // API methods
     void observe(Element*);
     void unobserve(Element*);
@@ -35,8 +35,16 @@ public:
 
 private:
 
+    using ObservationList = HeapLinkedHashSet<WeakMember<ResizeObservation>>;

[esprehn, 2016/07/21 17:52:29]

remove this, you only use it in one spot

[atotic1, 2016/07/21 19:15:00]

No. It is used in a later patch.

+
     explicit ResizeObserver(ResizeObserverCallback*, Document&);
 
+    Member<ResizeObserverCallback> m_callback;
+
+    // List of elements we are observing
+    ObservationList m_observations;
+
+    WeakMember<ResizeObserverController> m_controller;
 };