ResizeObserver implementation, part 2: lifetime

third_party/WebKit/Source/core/observer/ResizeObserverController.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ResizeObserverController_h
+#define ResizeObserverController_h
+
+#include "platform/heap/Handle.h"
+
+namespace blink {
+
+class ResizeObserver;
+
+// ResizeObserverController keeps track of all ResizeObservers
+// in a single Document.
+class ResizeObserverController : public GarbageCollected<ResizeObserverController> {

[esprehn, 2016/07/21 17:52:29]

final

[atotic1, 2016/07/21 19:15:00]

Done.

+

[esprehn, 2016/07/21 17:52:29]

remove blank line

[atotic1, 2016/07/21 19:15:00]

Done.

+public:
+

[esprehn, 2016/07/21 17:52:29]

you don't need all these blank lines around the public/private things

[atotic1, 2016/07/21 19:15:00]

Done.

+    ResizeObserverController();
+
+    void addObserver(ResizeObserver&);
+
+    DECLARE_TRACE();
+
+private:
+
+    using ObserverSet = HeapHashSet<WeakMember<ResizeObserver>>;

[esprehn, 2016/07/21 17:52:29]

remove

[atotic1, 2016/07/21 19:15:00]

I prefer naming complex containers. It spares me from parsing the declaration
trying to figure out what it does. Is this against G coding guidelines?

Done.

+    // Active observers
+    ObserverSet m_observers;
+};
+
+} // namespace blink
+
+#endif