Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: third_party/WebKit/Source/core/observer/ResizeObserver.cpp

Issue 2161313002: ResizeObserver implementation, part 2: lifetime (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/observer/ResizeObserver.h" 5 #include "core/observer/ResizeObserver.h"
6 6
7 #include "core/dom/Element.h" 7 #include "core/dom/Element.h"
8 #include "core/observer/ResizeObservation.h"
8 #include "core/observer/ResizeObserverCallback.h" 9 #include "core/observer/ResizeObserverCallback.h"
9 #include "core/observer/ResizeObserverEntry.h" 10 #include "core/observer/ResizeObserverController.h"
10 11
11 namespace blink { 12 namespace blink {
12 13
13 ResizeObserver* ResizeObserver::create(Document& document, ResizeObserverCallbac k* callback) 14 ResizeObserver* ResizeObserver::create(Document& document, ResizeObserverCallbac k* callback)
14 { 15 {
15 return new ResizeObserver(callback, document); 16 return new ResizeObserver(callback, document);
16 } 17 }
17 18
18 ResizeObserver::ResizeObserver(ResizeObserverCallback* callback, Document& docum ent) 19 ResizeObserver::ResizeObserver(ResizeObserverCallback* callback, Document& docum ent)
20 : m_callback(callback)
19 { 21 {
22 document.ensureResizeObserverController();
23 m_controller = document.resizeObserverController();
esprehn 2016/07/21 17:52:28 don't call it twice here, use the return value of
atotic1 2016/07/21 19:15:00 Done.
24 m_controller->addObserver(*this);
20 } 25 }
21 26
22 void ResizeObserver::observe(Element* target) 27 void ResizeObserver::observe(Element* target)
23 { 28 {
24 } 29 }
25 30
26 void ResizeObserver::unobserve(Element* target) 31 void ResizeObserver::unobserve(Element* target)
27 { 32 {
28 } 33 }
29 34
30 void ResizeObserver::disconnect() 35 void ResizeObserver::disconnect()
31 { 36 {
32 } 37 }
33 38
34 DEFINE_TRACE(ResizeObserver) 39 DEFINE_TRACE(ResizeObserver)
35 { 40 {
41 visitor->trace(m_callback);
42 visitor->trace(m_observations);
43 visitor->trace(m_controller);
36 } 44 }
37 45
38 } // namespace blink 46 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698