Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/runtime/runtime-debug.cc

Issue 2161263003: [debug] use catch prediction flag for promise rejections. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/parsing/parser.cc ('K') | « src/runtime/runtime.h ('k') | test/mjsunit/es6/debug-promises/throw-with-throw-in-reject.js » ('j') | test/mjsunit/es6/debug-promises/throw-with-throw-in-reject.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime/runtime-debug.cc
diff --git a/src/runtime/runtime-debug.cc b/src/runtime/runtime-debug.cc
index d885450a47e62af144c48f5a84ec35f50671b65e..e101f6a3db88cea9d7c1f6c239d75c40581e9d40 100644
--- a/src/runtime/runtime-debug.cc
+++ b/src/runtime/runtime-debug.cc
@@ -1754,11 +1754,10 @@ RUNTIME_FUNCTION(Runtime_DebugRecordAsyncFunction) {
}
RUNTIME_FUNCTION(Runtime_DebugPushPromise) {
- DCHECK(args.length() == 2);
+ DCHECK(args.length() == 1);
HandleScope scope(isolate);
CONVERT_ARG_HANDLE_CHECKED(JSObject, promise, 0);
- CONVERT_ARG_HANDLE_CHECKED(JSFunction, function, 1);
- isolate->PushPromise(promise, function);
+ isolate->PushPromise(promise);
return isolate->heap()->undefined_value();
}
« src/parsing/parser.cc ('K') | « src/runtime/runtime.h ('k') | test/mjsunit/es6/debug-promises/throw-with-throw-in-reject.js » ('j') | test/mjsunit/es6/debug-promises/throw-with-throw-in-reject.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698