Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: src/interpreter/control-flow-builders.h

Issue 2161263003: [debug] use catch prediction flag for promise rejections. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/control-flow-builders.h
diff --git a/src/interpreter/control-flow-builders.h b/src/interpreter/control-flow-builders.h
index dd8303ad9a0d37d8bbf88ebd5b7743d22f9b7870..8c81402008a0a59e46b3fcf7e58c2a4cf9b72b59 100644
--- a/src/interpreter/control-flow-builders.h
+++ b/src/interpreter/control-flow-builders.h
@@ -144,10 +144,11 @@ class SwitchBuilder final : public BreakableControlFlowBuilder {
// A class to help with co-ordinating control flow in try-catch statements.
class TryCatchBuilder final : public ControlFlowBuilder {
public:
- explicit TryCatchBuilder(BytecodeArrayBuilder* builder, bool catch_predicted)
+ explicit TryCatchBuilder(BytecodeArrayBuilder* builder,
+ HandlerTable::CatchPrediction catch_prediction)
: ControlFlowBuilder(builder),
handler_id_(builder->NewHandlerEntry()),
- catch_predicted_(catch_predicted) {}
+ catch_prediction_(catch_prediction) {}
void BeginTry(Register context);
void EndTry();
@@ -155,7 +156,7 @@ class TryCatchBuilder final : public ControlFlowBuilder {
private:
int handler_id_;
- bool catch_predicted_;
+ HandlerTable::CatchPrediction catch_prediction_;
BytecodeLabel handler_;
BytecodeLabel exit_;
};
@@ -165,10 +166,10 @@ class TryCatchBuilder final : public ControlFlowBuilder {
class TryFinallyBuilder final : public ControlFlowBuilder {
public:
explicit TryFinallyBuilder(BytecodeArrayBuilder* builder,
- bool catch_predicted)
+ HandlerTable::CatchPrediction catch_prediction)
: ControlFlowBuilder(builder),
handler_id_(builder->NewHandlerEntry()),
- catch_predicted_(catch_predicted),
+ catch_prediction_(catch_prediction),
finalization_sites_(builder->zone()) {}
void BeginTry(Register context);
@@ -180,7 +181,7 @@ class TryFinallyBuilder final : public ControlFlowBuilder {
private:
int handler_id_;
- bool catch_predicted_;
+ HandlerTable::CatchPrediction catch_prediction_;
BytecodeLabel handler_;
// Unbound labels that identify jumps to the finally block in the code.

Powered by Google App Engine
This is Rietveld 408576698