Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 2161253002: DevTools: Use proper target when processing worker thread events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
index 8445e62d03fc6af7cd28df2ca4b3a799acedf6e0..d820098231ae3e51260606272314989201bff53b 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
@@ -630,7 +630,7 @@ WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent = function(event, tar
*/
WebInspector.TimelineUIUtils.buildTraceEventDetails = function(event, model, linkifier, detailed, callback)
{
- var target = model.target();
+ var target = model.targetByEvent(event);
if (!target) {
callbackWrapper();
return;
@@ -693,7 +693,7 @@ WebInspector.TimelineUIUtils._buildTraceEventDetailsSynchronously = function(eve
// This message may vary per event.name;
var relatedNodeLabel;
- var contentHelper = new WebInspector.TimelineDetailsContentHelper(model.target(), linkifier);
+ var contentHelper = new WebInspector.TimelineDetailsContentHelper(model.targetByEvent(event), linkifier);
contentHelper.addSection(WebInspector.TimelineUIUtils.eventTitle(event), WebInspector.TimelineUIUtils.eventStyle(event).category);
var eventData = event.args["data"];
@@ -720,7 +720,7 @@ WebInspector.TimelineUIUtils._buildTraceEventDetailsSynchronously = function(eve
contentHelper.appendTextRow(WebInspector.UIString("Collected"), Number.bytesToString(delta));
break;
case recordTypes.JSFrame:
- var detailsNode = WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent(event, model.target(), linkifier);
+ var detailsNode = WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent(event, model.targetByEvent(event), linkifier);
if (detailsNode)
contentHelper.appendElementRow(WebInspector.UIString("Function"), detailsNode);
break;
@@ -849,7 +849,7 @@ WebInspector.TimelineUIUtils._buildTraceEventDetailsSynchronously = function(eve
break;
default:
- var detailsNode = WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent(event, model.target(), linkifier);
+ var detailsNode = WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent(event, model.targetByEvent(event), linkifier);
if (detailsNode)
contentHelper.appendElementRow(WebInspector.UIString("Details"), detailsNode);
break;
@@ -868,7 +868,7 @@ WebInspector.TimelineUIUtils._buildTraceEventDetailsSynchronously = function(eve
}
if (event.stackTrace || (event.initiator && event.initiator.stackTrace) || event.invalidationTrackingEvents)
- WebInspector.TimelineUIUtils._generateCauses(event, model.target(), relatedNodesMap, contentHelper);
+ WebInspector.TimelineUIUtils._generateCauses(event, model.targetByEvent(event), relatedNodesMap, contentHelper);
var showPieChart = detailed && WebInspector.TimelineUIUtils._aggregatedStatsForTraceEvent(stats, model, event);
if (showPieChart) {
@@ -972,7 +972,7 @@ WebInspector.TimelineUIUtils._collectAggregatedStatsForRecord = function(record,
*/
WebInspector.TimelineUIUtils.buildNetworkRequestDetails = function(request, model, linkifier)
{
- var target = model.target();
+ var target = model.targetByEvent(request.children[0]);
var contentHelper = new WebInspector.TimelineDetailsContentHelper(target, linkifier);
var duration = request.endTime - (request.startTime || -Infinity);

Powered by Google App Engine
This is Rietveld 408576698