Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 216123005: Don't expose WebKitShadowRoot constructor. (Closed)

Created:
6 years, 8 months ago by hayato
Modified:
6 years, 8 months ago
Reviewers:
esprehn, dglazkov
CC:
blink-reviews, arv+blink, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, rwlbuis, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Don't expose WebKitShadowRoot constructor. It's time to expose only ShadowRoot constructor. The chromium side patch is here: https://codereview.chromium.org/217013005/. BUG=242153 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170580

Patch Set 1 #

Patch Set 2 : reset results to fix end of line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -20 lines) Patch
M LayoutTests/fast/dom/shadow/resources/shadow-dom.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-root-js-api.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-root-js-api-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/shadow/ShadowRoot.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/frame/Window.idl View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hayato
PTAL.
6 years, 8 months ago (2014-03-31 06:39:02 UTC) #1
esprehn
On 2014/03/31 06:39:02, hayato wrote: > PTAL. All red bubbles, what happened?
6 years, 8 months ago (2014-03-31 08:30:04 UTC) #2
hayato
On 2014/03/31 08:30:04, esprehn wrote: > On 2014/03/31 06:39:02, hayato wrote: > > PTAL. > ...
6 years, 8 months ago (2014-03-31 09:34:07 UTC) #3
hayato
Other failures don't seem to be relevant to this patch. Let me check the results ...
6 years, 8 months ago (2014-03-31 09:35:57 UTC) #4
dglazkov
lgtm
6 years, 8 months ago (2014-04-01 16:03:58 UTC) #5
dglazkov
The CQ bit was checked by dglazkov@chromium.org
6 years, 8 months ago (2014-04-01 16:16:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/216123005/20001
6 years, 8 months ago (2014-04-01 16:16:06 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 16:25:20 UTC) #8
Message was sent while issue was closed. 
Change committed as 170580

Powered by Google App Engine
This is Rietveld 408576698