Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2577)

Unified Diff: blimp/client/BUILD.gn

Issue 2161223003: Adds GeolocationFeature for Blimp Geolocation project. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@engine_feature_prep
Patch Set: Makes UnexpectedMessage test work outside of debug Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | blimp/client/feature/DEPS » ('j') | blimp/client/feature/DEPS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/BUILD.gn
diff --git a/blimp/client/BUILD.gn b/blimp/client/BUILD.gn
index 8c536ea8b5ecca4f9354073b3ee1d7d2e412d1b0..10b13fdb4ca7d982197da0e2b0e01a48981fec71 100644
--- a/blimp/client/BUILD.gn
+++ b/blimp/client/BUILD.gn
@@ -93,6 +93,8 @@ source_set("feature") {
sources = [
"core/contents/tab_control_feature.cc",
"core/contents/tab_control_feature.h",
+ "feature/geolocation_feature.cc",
+ "feature/geolocation_feature.h",
"feature/ime_feature.cc",
"feature/ime_feature.h",
"feature/render_widget_feature.cc",
@@ -108,6 +110,7 @@ source_set("feature") {
"//cc",
"//cc/proto",
"//components/url_formatter",
+ "//device/geolocation:device_geolocation",
Kevin M 2016/08/15 20:35:40 Hm, this target should probably be named "geolocat
CJ 2016/08/15 21:59:31 yeah I agree. Not sure why it was made like that.
"//net:net",
"//skia",
"//ui/base/ime:text_input_types",
@@ -133,6 +136,7 @@ source_set("test_support") {
deps = [
":session",
+ "//device/geolocation:device_geolocation",
"//skia",
"//testing/gmock",
"//url",
@@ -198,6 +202,7 @@ source_set("feature_unit_tests") {
sources = [
"core/contents/tab_control_feature_unittest.cc",
"feature/compositor/blimp_compositor_manager_unittest.cc",
+ "feature/geolocation_feature_unittest.cc",
"feature/render_widget_feature_unittest.cc",
]
@@ -213,6 +218,8 @@ source_set("feature_unit_tests") {
"//blimp/net:test_support",
"//blimp/test:support",
"//cc/proto",
+ "//device/geolocation:device_geolocation",
+ "//device/geolocation:unittests",
"//net",
"//net:test_support",
"//skia",
« no previous file with comments | « no previous file | blimp/client/feature/DEPS » ('j') | blimp/client/feature/DEPS » ('J')

Powered by Google App Engine
This is Rietveld 408576698