blimp/client/BUILD.gn - Issue 2161223003: Adds GeolocationFeature for Blimp Geolocation project.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/BUILD.gn

Issue 2161223003: Adds GeolocationFeature for Blimp Geolocation project. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@engine_feature_prep

Patch Set: Addresses kmarshall's #8 comments and adds unittest Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/client/BUILD.gn

diff --git a/blimp/client/BUILD.gn b/blimp/client/BUILD.gn

index 32a5a43b478c1e954b94f017d5da0a6e8f4ff3dd..42eb9b9c598437d22a30b10014d79ab8b34b1cbc 100644

--- a/blimp/client/BUILD.gn

+++ b/blimp/client/BUILD.gn

@@ -125,6 +125,8 @@ source_set("app_unit_tests") {

source_set("feature") {

sources = [

+ "feature/geolocation_feature.cc",

+ "feature/geolocation_feature.h",

"feature/ime_feature.cc",

"feature/ime_feature.h",

"feature/navigation_feature.cc",

@@ -159,6 +161,8 @@ source_set("test_support") {

testonly = true

sources = [

+ "feature/mock_geolocation_feature_delegate.cc",

+ "feature/mock_geolocation_feature_delegate.h",

"feature/mock_ime_feature_delegate.cc",

"feature/mock_ime_feature_delegate.h",

"feature/mock_navigation_feature_delegate.cc",

@@ -240,6 +244,7 @@ source_set("feature_unit_tests") {

sources = [

"feature/compositor/blimp_client_picture_cache_unittest.cc",

"feature/compositor/blimp_compositor_manager_unittest.cc",

+ "feature/geolocation_feature_unittest.cc",

"feature/navigation_feature_unittest.cc",

"feature/render_widget_feature_unittest.cc",

"feature/tab_control_feature_unittest.cc",

« no previous file with comments | « no previous file | blimp/client/feature/geolocation_feature.h » ('j') | blimp/client/feature/geolocation_feature.h » ('J')