Adds GeolocationFeature for Blimp Geolocation project.

device/geolocation/fake_location_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// This file implements a mock location provider and the factory functions for
+// This file implements a fake location provider and the factory functions for
 // various ways of creating it.
 
-#include "device/geolocation/mock_location_provider.h"
+#include "device/geolocation/fake_location_provider.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/compiler_specific.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/memory/weak_ptr.h"
 #include "base/threading/thread_task_runner_handle.h"
 
 namespace device {
 
-MockLocationProvider::MockLocationProvider()
+FakeLocationProvider::FakeLocationProvider()
     : state_(STOPPED),
       is_permission_granted_(false),
       provider_task_runner_(base::ThreadTaskRunnerHandle::Get()) {}
 
-MockLocationProvider::~MockLocationProvider() {}
+FakeLocationProvider::~FakeLocationProvider() {}
 
-void MockLocationProvider::HandlePositionChanged(const Geoposition& position) {
+void FakeLocationProvider::HandlePositionChanged(const Geoposition& position) {
   if (provider_task_runner_->BelongsToCurrentThread()) {
     // The location arbitrator unit tests rely on this method running
     // synchronously.
     position_ = position;
     NotifyCallback(position_);
   } else {
     provider_task_runner_->PostTask(
-        FROM_HERE, base::Bind(&MockLocationProvider::HandlePositionChanged,
+        FROM_HERE, base::Bind(&FakeLocationProvider::HandlePositionChanged,
                               base::Unretained(this), position));
   }
 }
 
-bool MockLocationProvider::StartProvider(bool high_accuracy) {
+bool FakeLocationProvider::StartProvider(bool high_accuracy) {
   state_ = high_accuracy ? HIGH_ACCURACY : LOW_ACCURACY;
   return true;
 }
 
-void MockLocationProvider::StopProvider() {
+void FakeLocationProvider::StopProvider() {
   state_ = STOPPED;
 }
 
-void MockLocationProvider::GetPosition(Geoposition* position) {
+void FakeLocationProvider::GetPosition(Geoposition* position) {
   *position = position_;
 }
 
-void MockLocationProvider::OnPermissionGranted() {
+void FakeLocationProvider::OnPermissionGranted() {
   is_permission_granted_ = true;
 }
 
-// Mock location provider that automatically calls back its client at most
+// Fake location provider that automatically calls back its client at most

[Kevin M, 2016/08/15 20:35:40]

Is this class used anywhere in Chromium?

[CJ, 2016/08/15 21:59:32]

It is used in LocationArbitratorImplTest. 

 // once, when StartProvider or OnPermissionGranted is called. Use
 // |requires_permission_to_start| to select which event triggers the callback.
-class AutoMockLocationProvider : public MockLocationProvider {
+class AutoFakeLocationProvider : public FakeLocationProvider {
  public:
-  AutoMockLocationProvider(bool has_valid_location,
+  AutoFakeLocationProvider(bool has_valid_location,
                            bool requires_permission_to_start)
       : requires_permission_to_start_(requires_permission_to_start),
         listeners_updated_(false) {
     if (has_valid_location) {
       position_.accuracy = 3;
       position_.latitude = 4.3;
       position_.longitude = -7.8;
       // Webkit compares the timestamp to wall clock time, so we need it to be
       // contemporary.
       position_.timestamp = base::Time::Now();
     } else {
       position_.error_code = Geoposition::ERROR_CODE_POSITION_UNAVAILABLE;
     }
   }
   bool StartProvider(bool high_accuracy) override {
-    MockLocationProvider::StartProvider(high_accuracy);
+    FakeLocationProvider::StartProvider(high_accuracy);
     if (!requires_permission_to_start_) {
       UpdateListenersIfNeeded();
     }
     return true;
   }
 
   void OnPermissionGranted() override {
-    MockLocationProvider::OnPermissionGranted();
+    FakeLocationProvider::OnPermissionGranted();
     if (requires_permission_to_start_) {
       UpdateListenersIfNeeded();
     }
   }
 
   void UpdateListenersIfNeeded() {
     if (!listeners_updated_) {
       listeners_updated_ = true;
       base::ThreadTaskRunnerHandle::Get()->PostTask(
-          FROM_HERE, base::Bind(&MockLocationProvider::HandlePositionChanged,
+          FROM_HERE, base::Bind(&FakeLocationProvider::HandlePositionChanged,
                                 base::Unretained(this), position_));
     }
   }
 
  private:
   const bool requires_permission_to_start_;
   bool listeners_updated_;
 
-  DISALLOW_COPY_AND_ASSIGN(AutoMockLocationProvider);
+  DISALLOW_COPY_AND_ASSIGN(AutoFakeLocationProvider);
 };
 
-LocationProvider* NewMockLocationProvider() {
-  return new MockLocationProvider;
+LocationProvider* NewFakeLocationProvider() {

[Kevin M, 2016/08/15 20:35:40]

1. These helper methods are very unusual. Generally speaking, picking and naming
sensible constructor parameters are the way to go. If a nullable return value is
desired, then a static Create method can be useful, but that doesn't appear to
be the case here. 
2. I don't see any callers for NewMockLocationProvider, and
NewAutoSuccessMockLocationProvider in the current codebase.

I recommend deleting these helper methods and replacing their callers (if they
exist) with direct calls to the constructor.

[CJ, 2016/08/15 21:59:32]

Done.

[Kevin M, 2016/08/17 00:55:02]

They're still here... :)

[CJ, 2016/08/18 00:58:49]

Still there? Are you saying you want the class AutoFakeLocationProvider also
removed?

+  return new FakeLocationProvider;
 }
 
-LocationProvider* NewAutoSuccessMockLocationProvider() {
-  return new AutoMockLocationProvider(true, false);
+LocationProvider* NewAutoSuccessFakeLocationProvider() {
+  return new AutoFakeLocationProvider(true, false);
 }
 
-LocationProvider* NewAutoFailMockLocationProvider() {
-  return new AutoMockLocationProvider(false, false);
+LocationProvider* NewAutoFailFakeLocationProvider() {
+  return new AutoFakeLocationProvider(false, false);
 }
 
-LocationProvider* NewAutoSuccessMockNetworkLocationProvider() {
-  return new AutoMockLocationProvider(true, true);
+LocationProvider* NewAutoSuccessFakeNetworkLocationProvider() {
+  return new AutoFakeLocationProvider(true, true);
 }
 
 }  // namespace device