TaskScheduler: Bump thread priority during shutdown.

base/task_scheduler/scheduler_worker_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/task_scheduler/scheduler_worker.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/synchronization/condition_variable.h"
+#include "base/synchronization/waitable_event.h"
 #include "base/task_scheduler/scheduler_lock.h"
 #include "base/task_scheduler/sequence.h"
 #include "base/task_scheduler/task.h"
 #include "base/task_scheduler/task_tracker.h"
+#include "base/threading/platform_thread.h"
 #include "base/time/time.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace base {
 namespace internal {
 namespace {
 
 const size_t kNumSequencesPerTest = 150;
 
 // The test parameter is the number of Tasks per Sequence returned by GetWork().
@@ skipping 383 matching lines @@
           ThreadPriority::NORMAL, WrapUnique(delegate), &task_tracker,
           SchedulerWorker::InitialState::DETACHED);
   ASSERT_FALSE(worker->ThreadAliveForTesting());
   worker->WakeUp();
   delegate->WaitForWorkToRun();
   delegate->WaitForDetachRequest();
   ASSERT_TRUE(worker->ThreadAliveForTesting());
   worker->JoinForTesting();
 }
 
+namespace {
+
+class ExpectNormalPriorityDelegate : public SchedulerWorker::Delegate {
+ public:
+  ExpectNormalPriorityDelegate()
+      : get_work_event_(WaitableEvent::ResetPolicy::MANUAL,
+                        WaitableEvent::InitialState::NOT_SIGNALED) {}
+
+  void WaitForGetWork() { get_work_event_.Wait(); }
+
+  // SchedulerWorker::Delegate:
+  void OnMainEntry(SchedulerWorker* worker) override {}
+  scoped_refptr<Sequence> GetWork(SchedulerWorker* worker) override {
+    EXPECT_EQ(ThreadPriority::NORMAL,
+              PlatformThread::GetCurrentThreadPriority());
+    get_work_event_.Signal();
+    return nullptr;
+  }
+  void ReEnqueueSequence(scoped_refptr<Sequence> sequence) override {}
+  TimeDelta GetSleepTimeout() override { return TimeDelta::Max(); }
+  bool CanDetach(SchedulerWorker* worker) override { return false; }
+
+ private:
+  WaitableEvent get_work_event_;
+
+  DISALLOW_COPY_AND_ASSIGN(ExpectNormalPriorityDelegate);
+};
+
+}  // namespace
+
+TEST(TaskSchedulerWorkerTest, BumpPriorityDuringShutdown) {
+  TaskTracker task_tracker;
+  task_tracker.SetHasShutdownStartedForTesting();

[gab, 2016/07/20 18:35:36]

Just to make sure, if you comment out this line, the test fails, right?

I'd be more comfortable if the test was tested, currently it could pass in a
number of ways with a bug elsewhere in the code it feels.

How about have an ExpectPriorityDelegate on which the expectation can be
updated. Then verify that a first task runs in BACKGROUND mode, then set
shutdown, and verify priority of next task?

Also, instead of doing the verifications in the Delegate I think we should post
actual tasks and do the verification inside of them -- so maybe this test
belongs more as an integration test at the SWPool level.

[fdoray, 2016/07/20 20:30:37]

As discussed offline, implemented ExpectPriorityDelegate.

+
+  ExpectNormalPriorityDelegate* delegate = new ExpectNormalPriorityDelegate;

[gab, 2016/07/20 18:35:36]

Bind to unique_ptr here and move it below (or WrapUnique the inline new call --
that's what WrapUnique is meant for)

[fdoray, 2016/07/20 20:30:37]

Done.

+  std::unique_ptr<SchedulerWorker> worker = SchedulerWorker::Create(
+      ThreadPriority::BACKGROUND, WrapUnique(delegate), &task_tracker,
+      SchedulerWorker::InitialState::ALIVE);
+  worker->WakeUp();
+  delegate->WaitForGetWork();
+  worker->JoinForTesting();
+}
+
 }  // namespace
 }  // namespace internal
 }  // namespace base